Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ESM Support #35

Open
Ezard opened this issue Apr 29, 2022 · 1 comment · May be fixed by #43
Open

[Feature] ESM Support #35

Ezard opened this issue Apr 29, 2022 · 1 comment · May be fixed by #43
Labels
Feature Request help wanted Extra attention is needed

Comments

@Ezard
Copy link

Ezard commented Apr 29, 2022

Would you be open to building the project as both a CommonJS package and an ESM package?
This way, users who bundle their code can benefit from tree-shaking (and the Node ecosystem is moving in this direction in general)

This should be a fairly simple change that can be handled purely via tsconfig i.e. no code changes required

Since the project will be built as both CJS and ESM, any projects that can only consume CJS packages will still work without any issues

I'm happy to submit a PR for this if wanted :)

@nonara nonara changed the title ESM Support [Feature] ESM Support Aug 10, 2022
@nonara
Copy link
Collaborator

nonara commented Aug 10, 2022

Thanks for the suggestion @Ezard !

I would be grateful for the PR. My knowledge on ESM is still a bit lacking. When I worked with it, there were still many issues, and it wasn't a good idea to implement. I recognize that things have changed a bit since then.

At any rate, I appreciate the help! If you open a PR, I will help get it pushed through.

@nonara nonara added help wanted Extra attention is needed Feature Request labels Aug 10, 2022
@SettingDust SettingDust linked a pull request Nov 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants