Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Table parsing issue #38

Open
long20014 opened this issue Jun 9, 2022 · 3 comments
Open

[Bug] Table parsing issue #38

long20014 opened this issue Jun 9, 2022 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@long20014
Copy link

long20014 commented Jun 9, 2022

The content and rawRows look like this.
image

There is an issue with making rawRows (in config.js), which cause an incorrect result. It is missing the first empty cell.
Screen Shot 2022-06-09 at 10 17 32

this result should be ['', 'Purpose', 'Region']

@nonara nonara added bug Something isn't working help wanted Extra attention is needed labels Oct 26, 2022
@nonara
Copy link
Collaborator

nonara commented Oct 26, 2022

Thank you for pointing this out, and sorry for the delayed response.

It sounds like the issue is an empty <td> is breaking it. Is that right? Do you have a sample of the HTML that doing it?

Also, if you or anyone else would like to help with a PR on this, it would be appreciated!

@BasVerdoorn
Copy link

@nonara could you see if the fix from smervs (see pull request) works and then accept this pull request? thank you in advance.

pull request: #47
github repo: https://github.com/smervs/node-html-markdown

@kloetzl
Copy link

kloetzl commented Jul 9, 2023

I hit the same snag with some HTML files of mine. Great to see that there is already a proposed fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants