-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] The issue with the Heading wrapped inside a link #46
Comments
Hi Viktor. Thank you for the report & kind words. You're right that this isn't ideal. I will give some thought on how to approach this. Can you give some more detail on the multiline code issue (an example, preferably). Code fencing should be working properly. |
Yes, sure here is an example of the HTML and when converting to markdown it converts to plain text without wrapping code into backticks Sorry for the extended example, but that's how the code example looks from the NextJS site. <pre class="prism-code language-typescript" style="color: rgb(248, 248, 242); background-color: rgb(40, 42, 54);"><div class="sc-36549842-4 bmkFVs"></div><div class="sc-36549842-0 kfTyDW token-line" style="color: rgb(248, 248, 242);"><span class="sc-36549842-1 eePLWY">1</span><span class="sc-36549842-2 fODbQc"><span class="token keyword" style="color: rgb(189, 147, 249); font-style: italic;">class</span><span class="token plain"> </span><span class="token class-name">Invoice</span><span class="token plain"> </span><span class="token punctuation" style="color: rgb(248, 248, 242);">{</span><span class="token plain"></span></span></div><div class="sc-36549842-0 kfTyDW token-line" style="color: rgb(248, 248, 242);"><span class="sc-36549842-1 eePLWY">2</span><span class="sc-36549842-2 fODbQc"><span class="token plain"> </span><span class="token function" style="color: rgb(80, 250, 123);">constructor</span><span class="token punctuation" style="color: rgb(248, 248, 242);">(</span><span class="token keyword" style="color: rgb(189, 147, 249); font-style: italic;">public</span><span class="token plain"> persistanceStorage</span><span class="token operator">:</span><span class="token plain"> PersistanceStorage</span><span class="token punctuation" style="color: rgb(248, 248, 242);">)</span><span class="token plain"> </span><span class="token punctuation" style="color: rgb(248, 248, 242);">{</span><span class="token punctuation" style="color: rgb(248, 248, 242);">}</span><span class="token plain"></span></span></div><div class="sc-36549842-0 kfTyDW token-line" style="color: rgb(248, 248, 242);"><span class="sc-36549842-1 eePLWY">3</span><span class="sc-36549842-2 fODbQc"><span class="token plain" style="display: inline-block;">
</span></span></div><div class="sc-36549842-0 kfTyDW token-line" style="color: rgb(248, 248, 242);"><span class="sc-36549842-1 eePLWY">4</span><span class="sc-36549842-2 fODbQc"><span class="token plain"> </span><span class="token keyword" style="color: rgb(189, 147, 249); font-style: italic;">public</span><span class="token plain"> </span><span class="token keyword" style="color: rgb(189, 147, 249); font-style: italic;">async</span><span class="token plain"> </span><span class="token function" style="color: rgb(80, 250, 123);">persistInvoice</span><span class="token punctuation" style="color: rgb(248, 248, 242);">(</span><span class="token plain">data</span><span class="token punctuation" style="color: rgb(248, 248, 242);">)</span><span class="token plain"> </span><span class="token punctuation" style="color: rgb(248, 248, 242);">{</span><span class="token plain"></span></span></div><div class="sc-36549842-0 kfTyDW token-line" style="color: rgb(248, 248, 242);"><span class="sc-36549842-1 eePLWY">5</span><span class="sc-36549842-2 fODbQc"><span class="token plain"> </span><span class="token keyword" style="color: rgb(189, 147, 249); font-style: italic;">this</span><span class="token punctuation" style="color: rgb(248, 248, 242);">.</span><span class="token plain">persistanceStorage</span><span class="token punctuation" style="color: rgb(248, 248, 242);">.</span><span class="token function" style="color: rgb(80, 250, 123);">saveData</span><span class="token punctuation" style="color: rgb(248, 248, 242);">(</span><span class="token plain">data</span><span class="token punctuation" style="color: rgb(248, 248, 242);">)</span><span class="token punctuation" style="color: rgb(248, 248, 242);">;</span><span class="token plain"></span></span></div><div class="sc-36549842-0 kfTyDW token-line" style="color: rgb(248, 248, 242);"><span class="sc-36549842-1 eePLWY">6</span><span class="sc-36549842-2 fODbQc"><span class="token plain"> </span><span class="token punctuation" style="color: rgb(248, 248, 242);">}</span><span class="token plain"></span></span></div><div class="sc-36549842-0 kfTyDW token-line" style="color: rgb(248, 248, 242);"><span class="sc-36549842-1 eePLWY">7</span><span class="sc-36549842-2 fODbQc"><span class="token plain"></span><span class="token punctuation" style="color: rgb(248, 248, 242);">}</span></span></div></pre> |
Ah, ok. Thanks for the example! Yes, we do handle Try wrapping with |
Thank you, wrapping inside the |
Hey! First of all would like to thank you for such a great library!
Noticed a few issues when generating Markdown.
I have the following HTML:
It produces the following Markdown
Expected output would be:
Another issue I've encountered is that multiline code is not wrapped to the backticks, but i guess i can open another issue for this.
The text was updated successfully, but these errors were encountered: