Reject events promises when the client is disconnected #565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit
Fixes an issues where concurrent close calls don't call all the callbacks.
Before: Only
2
was printed.After: Both
1
and2
are printed.Side-note: not calling the
'disconnect'
event on user-initiated close seems like a strange API design decision.I kept this behavior here, but I think you should consider changing this in the future (or at least add an event emitted in both cases).
Second commit
Ensures that promises waiting for CDP events are rejected when the client disconnects.
It's like #489, but for the events instead of commands.
Before: The promise was waiting forever.
After: The promise is rejected with a
'client disconnected'
error.