Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert.exists Webdriver command fails, but Dalek reports success #13

Open
niallo opened this issue Aug 6, 2014 · 1 comment
Open

assert.exists Webdriver command fails, but Dalek reports success #13

niallo opened this issue Aug 6, 2014 · 1 comment
Assignees
Labels

Comments

@niallo
Copy link
Contributor

niallo commented Aug 6, 2014

Let's say we run an assert.exists with an invalid selector such as:

.assert.exists('h1:contains("FOoooooooooooooo")','LIAR!!!!!!!!')

The Webdriver response is pretty clear that there has been an error, but Dalek still things it succeeded:

☁ [WEBDRIVER] webdriver: 200 POST /session/5600592b61bb652f2f6175d96484529c/element
☁ [WEBDRIVER] webdriver: {"sessionId":"5600592b61bb652f2f6175d96484529c","status":12,"value":{"message":"invalid element state: Failed to execute 'querySelector' on 'Document': 'h1:contains(\"FOoooooooooooooo\")' is not a valid selector.\n  (Session info: chrome=36.0.1985.125)\n  (Driver info: chromedriver=2.9.248307,platform=Mac OS X 10.9.3 x86_64)"}}
✔ EXISTS LIAR!!!!!!!!
@asciidisco
Copy link
Member

I see, I do not check for this status code properly, will be fixed in 0.0.9

@asciidisco asciidisco self-assigned this Aug 13, 2014
@asciidisco asciidisco added the bug label Aug 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants