Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setup.py script #4

Open
danilobellini opened this issue Sep 22, 2016 · 1 comment
Open

Add a setup.py script #4

danilobellini opened this issue Sep 22, 2016 · 1 comment

Comments

@danilobellini
Copy link
Owner

A setup script is missing for this project.

The installation could include a fractal script, besides the python -m fractal command.

Also, it would be nice to include an update to README.rst to use the new entry point in the examples, as well as installation instructions.

Tox wouldn't run the test suite the same way it does today, as skipsdist wouldn't be required anymore.

@danilobellini
Copy link
Owner Author

This was addressed by this commit.

It's still missing some important stuff like installation instructions and an image URL converter to use the URL from the GitHub repository on the egg PKG-INFO metadata. Perhaps the README generator script may be re-used by the setup script for creating the long description metadata.

Should the package name be kept fractals with the trailing s? The module file (and therefore the entry point) doesn't have an s, should it get an extra s?

The fractal script weren't add, but should it really be included? It's probably easier than python -m fractal, but that's clearly not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant