Add couple of clarifying comments

danpashin · Jun 26, 2024 · 06b5909 · 06b5909
1 parent ec9b324
commit 06b5909
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/twackup-gui/Twackup/Sources/FFI Models/DpkgProgressNotifier.swift b/twackup-gui/Twackup/Sources/FFI Models/DpkgProgressNotifier.swift
@@ -41,7 +41,8 @@ final class DpkgProgressNotifier: @unchecked Sendable {
     // MARK: - Private methods
 
     private func initFuncs() {
-        ffiFunctions.context = Unmanaged.passUnretained(self).toOpaque()
+        // Temporarily make a leak and consume it in finished_all func
+        ffiFunctions.context = Unmanaged.passRetained(self).toOpaque()
         ffiFunctions.started_processing = { context, package in
             guard let context, let ffiPackage = FFIPackage(package) else {
                 tw_package_release(package.inner)
@@ -66,7 +67,7 @@ final class DpkgProgressNotifier: @unchecked Sendable {
         ffiFunctions.finished_all = { context in
             guard let context else { return }
 
-            let dpkg = Unmanaged<DpkgProgressNotifier>.fromOpaque(context).takeUnretainedValue()
+            let dpkg = Unmanaged<DpkgProgressNotifier>.fromOpaque(context).takeRetainedValue()
             dpkg.finishedAll()
         }
     }

diff --git a/twackup-gui/Twackup/Sources/FFI Models/FFILogger.swift b/twackup-gui/Twackup/Sources/FFI Models/FFILogger.swift
@@ -56,6 +56,11 @@ actor FFILogger {
         }
 
         var funcs = TwLogFunctions()
+        // Intented leak since logger can be deinited in Swift but pointer will be saved by Rust struct
+        // and it will crash in some of this C-style handlers
+        //
+        // Maybe there should be some kind of `deinit` func which will balance RC
+        // but Rust log crate doesn't support deiniting yet
         funcs.context = Unmanaged<FFILogger>.passRetained(self).toOpaque()
         funcs.log = { context, ffiMsg, level in
             guard let context,