feat: some steps to make iceberg work #79
Annotations
31 errors and 5 warnings
Rust formatting
Process completed with exit code 1.
|
the borrowed expression implements the required traits:
src/catalog_provider/glue.rs#L260
error: the borrowed expression implements the required traits
--> src/catalog_provider/glue.rs:260:32
|
260 | ... let path = Path::parse(&strip_prefix(metadata_location)).map_err(|_| GlueError::Other(format!("Failed to parse {} as path", metadat...
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `strip_prefix(metadata_location)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
useless use of `format!`:
src/catalog_provider/glue.rs#L259
error: useless use of `format!`
--> src/catalog_provider/glue.rs:259:96
|
259 | ...ion").ok_or(GlueError::AWS(format!("Did not find metadata_location property in glue catalog")))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Did not find metadata_location property in glue catalog".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `-D clippy::useless-format` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
|
the borrowed expression implements the required traits:
src/catalog_provider/glue.rs#L260
error: the borrowed expression implements the required traits
--> src/catalog_provider/glue.rs:260:32
|
260 | ... let path = Path::parse(&strip_prefix(metadata_location)).map_err(|_| GlueError::Other(format!("Failed to parse {} as path", metadat...
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `strip_prefix(metadata_location)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
useless use of `format!`:
src/catalog_provider/glue.rs#L259
error: useless use of `format!`
--> src/catalog_provider/glue.rs:259:96
|
259 | ...ion").ok_or(GlueError::AWS(format!("Did not find metadata_location property in glue catalog")))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Did not find metadata_location property in glue catalog".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `-D clippy::useless-format` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
|
unused variable: `sd`:
src/catalog_provider/glue.rs#L248
error: unused variable: `sd`
--> src/catalog_provider/glue.rs:248:9
|
248 | sd: &StorageDescriptor,
| ^^ help: if this is intentional, prefix it with an underscore: `_sd`
|
unused variable: `sd`:
src/catalog_provider/glue.rs#L248
error: unused variable: `sd`
--> src/catalog_provider/glue.rs:248:9
|
248 | sd: &StorageDescriptor,
| ^^ help: if this is intentional, prefix it with an underscore: `_sd`
|
unused variable: `table_name`:
src/catalog_provider/glue.rs#L247
error: unused variable: `table_name`
--> src/catalog_provider/glue.rs:247:9
|
247 | table_name: &str,
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_name`
|
unused variable: `table_name`:
src/catalog_provider/glue.rs#L247
error: unused variable: `table_name`
--> src/catalog_provider/glue.rs:247:9
|
247 | table_name: &str,
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_name`
|
unused variable: `database_name`:
src/catalog_provider/glue.rs#L246
error: unused variable: `database_name`
--> src/catalog_provider/glue.rs:246:9
|
246 | database_name: &str,
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_database_name`
|
unused variable: `database_name`:
src/catalog_provider/glue.rs#L246
error: unused variable: `database_name`
--> src/catalog_provider/glue.rs:246:9
|
246 | database_name: &str,
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_database_name`
|
unused variable: `ctx`:
src/catalog_provider/glue.rs#L245
error: unused variable: `ctx`
--> src/catalog_provider/glue.rs:245:9
|
245 | ctx: &SessionState,
| ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`
|
unused variable: `ctx`:
src/catalog_provider/glue.rs#L245
error: unused variable: `ctx`
--> src/catalog_provider/glue.rs:245:9
|
245 | ctx: &SessionState,
| ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`
|
unused variable: `table_registration_options`:
src/catalog_provider/glue.rs#L244
error: unused variable: `table_registration_options`
--> src/catalog_provider/glue.rs:244:9
|
244 | table_registration_options: &TableRegistrationOptions,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_registration_options`
|
unused variable: `table_registration_options`:
src/catalog_provider/glue.rs#L244
error: unused variable: `table_registration_options`
--> src/catalog_provider/glue.rs:244:9
|
244 | table_registration_options: &TableRegistrationOptions,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_registration_options`
|
unused variable: `glue_table`:
src/catalog_provider/glue.rs#L243
error: unused variable: `glue_table`
--> src/catalog_provider/glue.rs:243:9
|
243 | glue_table: &Table,
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_glue_table`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
|
unused variable: `glue_table`:
src/catalog_provider/glue.rs#L243
error: unused variable: `glue_table`
--> src/catalog_provider/glue.rs:243:9
|
243 | glue_table: &Table,
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_glue_table`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
|
unused import: `iceberg_rust::util`:
src/catalog_provider/glue.rs#L31
error: unused import: `iceberg_rust::util`
--> src/catalog_provider/glue.rs:31:5
|
31 | use iceberg_rust::util;
| ^^^^^^^^^^^^^^^^^^
|
unused import: `iceberg_rust::table::table_builder::TableBuilder`:
src/catalog_provider/glue.rs#L30
error: unused import: `iceberg_rust::table::table_builder::TableBuilder`
--> src/catalog_provider/glue.rs:30:5
|
30 | use iceberg_rust::table::table_builder::TableBuilder;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `iceberg_rust::error::Error::TableMetadataBuilder`:
src/catalog_provider/glue.rs#L28
error: unused import: `iceberg_rust::error::Error::TableMetadataBuilder`
--> src/catalog_provider/glue.rs:28:5
|
28 | use iceberg_rust::error::Error::TableMetadataBuilder;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `iceberg_rust::catalog::Catalog`:
src/catalog_provider/glue.rs#L27
error: unused import: `iceberg_rust::catalog::Catalog`
--> src/catalog_provider/glue.rs:27:5
|
27 | use iceberg_rust::catalog::Catalog;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `std::io::Cursor`:
src/catalog_provider/glue.rs#L24
error: unused import: `std::io::Cursor`
--> src/catalog_provider/glue.rs:24:5
|
24 | use std::io::Cursor;
| ^^^^^^^^^^^^^^^
|
unused import: `aws_config::BehaviorVersion`:
src/catalog_provider/glue.rs#L5
error: unused import: `aws_config::BehaviorVersion`
--> src/catalog_provider/glue.rs:5:5
|
5 | use aws_config::BehaviorVersion;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
|
unused import: `iceberg_rust::util`:
src/catalog_provider/glue.rs#L31
error: unused import: `iceberg_rust::util`
--> src/catalog_provider/glue.rs:31:5
|
31 | use iceberg_rust::util;
| ^^^^^^^^^^^^^^^^^^
|
unused import: `iceberg_rust::table::table_builder::TableBuilder`:
src/catalog_provider/glue.rs#L30
error: unused import: `iceberg_rust::table::table_builder::TableBuilder`
--> src/catalog_provider/glue.rs:30:5
|
30 | use iceberg_rust::table::table_builder::TableBuilder;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `iceberg_rust::error::Error::TableMetadataBuilder`:
src/catalog_provider/glue.rs#L28
error: unused import: `iceberg_rust::error::Error::TableMetadataBuilder`
--> src/catalog_provider/glue.rs:28:5
|
28 | use iceberg_rust::error::Error::TableMetadataBuilder;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `iceberg_rust::catalog::Catalog`:
src/catalog_provider/glue.rs#L27
error: unused import: `iceberg_rust::catalog::Catalog`
--> src/catalog_provider/glue.rs:27:5
|
27 | use iceberg_rust::catalog::Catalog;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `std::io::Cursor`:
src/catalog_provider/glue.rs#L24
error: unused import: `std::io::Cursor`
--> src/catalog_provider/glue.rs:24:5
|
24 | use std::io::Cursor;
| ^^^^^^^^^^^^^^^
|
unused import: `aws_config::BehaviorVersion`:
src/catalog_provider/glue.rs#L5
error: unused import: `aws_config::BehaviorVersion`
--> src/catalog_provider/glue.rs:5:5
|
5 | use aws_config::BehaviorVersion;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
|
Clippy (amd64, stable)
Clippy had exited with the 101 exit code
|
Test (amd64, stable)
Process completed with exit code 101.
|
Rust formatting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Clippy (amd64, stable)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, scherermichael-oss/[email protected], actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Clippy (amd64, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: scherermichael-oss/[email protected], actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (amd64, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test (amd64, stable)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|