Skip to content

Commit

Permalink
minor: add ticket references to upstream tickets (#156)
Browse files Browse the repository at this point in the history
I just filed a bunch of improvements in Datafusion as part of
apache/datafusion#12550 and I want to add
links to the code to remember when I can remove the workarounds in dft
  • Loading branch information
alamb authored Sep 20, 2024
1 parent a155b75 commit fbb039f
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/extensions/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,15 @@ use std::sync::Arc;
///
/// List of things that would be nice to add upstream:
/// TODO: Implement Debug for SessionStateBuilder upstream
/// TODO: Implement with_table_factory to add a single TableProviderFactory to the list of factories
/// <https://github.com/apache/datafusion/issues/12555>
/// TODO: Implement some way to get access to the current RuntimeEnv (to register object stores)
/// <https://github.com/apache/datafusion/issues/12553>
/// TODO: Implement a way to add just a single TableProviderFactory
/// <https://github.com/apache/datafusion/issues/12552>
/// TODO: Make TableFactoryProvider implement Debug
/// TODO: rename RuntimeEnv::new() to RuntimeEnv::try_new() as it returns a Result
/// <https://github.com/apache/datafusion/pull/12557>
/// TODO: rename RuntimeEnv::new() to RuntimeEnv::try_new() as it returns a Result:
/// <https://github.com/apache/datafusion/issues/12554>
//#[derive(Debug)]
pub struct DftSessionStateBuilder {
session_config: SessionConfig,
Expand Down

0 comments on commit fbb039f

Please sign in to comment.