Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate sqllogictest for Testing #3

Open
demetribu opened this issue Sep 23, 2024 · 5 comments
Open

Integrate sqllogictest for Testing #3

demetribu opened this issue Sep 23, 2024 · 5 comments
Assignees

Comments

@demetribu
Copy link
Collaborator

We aim to integrate the sqllogictest crate to assist in testing the project. While we will reuse some parts of the existing sqllogictest runner in DataFusion, the goal is to implement a simpler version tailored to our needs.

@jatin510
Copy link
Contributor

Hello @dmitrybugakov,

I'm interested in working on this task and would appreciate some guidance on how to get started.
Could you also help me understand the scope of this task so I can approach it effectively?

I’m eager to contribute and make meaningful progress.

@demetribu
Copy link
Collaborator Author

Hello @jatin510

Thank you for your contributions. Regarding this task, we had a discussion with @alamb #2 (comment)
and it seems to me, we are good with using insta.rs for now.

@jatin510
Copy link
Contributor

#7 (comment)

Based on this conversation. Can we start working on this?

Right now,

  • now adding tests are more time consuming with insta.rs
  • we need to take care of formatting while writing test

@alamb
Copy link
Contributor

alamb commented Sep 28, 2024

Nice! This sounds like a great think to work on to me. Good luck and I can't wait to see how it goes

@demetribu demetribu reopened this Sep 28, 2024
@jatin510
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants