Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default plain-text ingestion fails on empty lines #77

Open
nblumhardt opened this issue Oct 24, 2018 · 2 comments
Open

Default plain-text ingestion fails on empty lines #77

nblumhardt opened this issue Oct 24, 2018 · 2 comments

Comments

@nblumhardt
Copy link
Member

E.g. in PowerShell, in a non-empty folder, running:

ls | seqcli ingest

Produces:

Ingestion failed: A line arrived late or could not be parsed: ``.
System.IO.InvalidDataException: A line arrived late or could not be parsed: ``.
   at SeqCli.PlainText.PlainTextLogEventReader.TryReadAsync() in C:\projects\seqcli\src\SeqCli\PlainText\PlainTextLogEventReader.cs:line 36
   at SeqCli.Ingestion.LogShipper.ReadBatchAsync(ILogEventReader reader, Func`2 filter, Int32 count, InvalidDataHandling invalidDataHandling) in C:\projects\seqcli\src\SeqCli\Ingestion\LogShipper.cs:line 94
   at SeqCli.Ingestion.LogShipper.ShipEvents(SeqConnection connection, ILogEventReader reader, List`1 enrichers, InvalidDataHandling invalidDataHandling, SendFailureHandling sendFailureHandling, Func`2 filter) in C:\projects\seqcli\src\SeqCli\Ingestion\LogShipper.cs:line 50
   at SeqCli.Cli.Commands.IngestCommand.Run() in C:\projects\seqcli\src\SeqCli\Cli\Commands\IngestCommand.cs:line 90
@nblumhardt nblumhardt added the bug Something isn't working label Oct 24, 2018
@nblumhardt nblumhardt added this to the 5.0 milestone Oct 24, 2018
@nblumhardt
Copy link
Member Author

This is easy to work around with --invalid-data=ignore; we should take a closer look at scenarios to see whether empty lines can be considered "valid" by the default template.

@nblumhardt nblumhardt added discussion and removed bug Something isn't working labels Jan 8, 2019
@nblumhardt
Copy link
Member Author

Unsure whether we should assign bug status to this, or if the way we handle empty lines should be re-thought.

@nblumhardt nblumhardt removed this from the 5.0 Maintenance Release 1 milestone Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant