-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(7): Containerize your app: how Uber moves big data in hours #66
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hunain <[email protected]>
@nkkko are we moving towards assigning and finalizing this one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives me mixed feelings. Are you sure those are appropriate examples. I am not convinced by your article. Also you use Uber in the title, but that is just one of your examples. You should have invested more effort.
@nkkko one thing I'm confident about is the authenticity and relevance of these examples. I've read companies own published blogs like Netflix and Uber, which released it in context of containerization itself, and it took significant effort and time. I've also added the references for further confirmation. I will work on the title, please tell what else needs changes, will be more than happy to improve. |
@mojafa what is the update on this one ? There was no response on this, should I close this PR ? This took significant research and effort. |
@hunxjunedo Please gimme till end of day to get back on this. I'll rereview it |
@mojafa hey, any luck with that? |
@hunxjunedo here are my comments:
Please put in more effort and finalise this |
98837a7
to
143e9e6
Compare
@mojafa I've made the requested changes, to be more specific:
please feel free to request more changes in the loop! |
@hunxjunedo I wanted to let you know that I've just pushed some changes to the main branch that fix some linting issues and update the compliance rules. These updates should help you pass the content compliance checks in your current pull request. When you get a chance, please pull the latest changes from the main branch into your working branch. This should make the integration smoother and help avoid any potential conflicts. |
@mojafa , terribly sorry about the title in the metadata, really forgot to remove that. |
Signed-off-by: Jaafar <[email protected]> Signed-off-by: hunxjunedo <[email protected]>
Signed-off-by: Jaafar <[email protected]> Signed-off-by: hunxjunedo <[email protected]>
Signed-off-by: Jaafar <[email protected]> Signed-off-by: hunxjunedo <[email protected]>
Signed-off-by: hunxjunedo <[email protected]>
143e9e6
to
6cf0572
Compare
@mojafa This one's ready, however, I had to add line breaks to make lint pass, dk how that's supposed to work. |
@mojafa can we finalize this one ? Is the quality unsatisfactory? |
@hunxjunedo we're not there yet. also the tone of the article is not as technical. Can I close this PR while you pick up another issue? There's two other submissions doe this issue |
@mojafa It's up to you, but there is a reason for the tone to not be technical, I wrote a bunch of articles for Tailcall, and the devrel actually suggested to make the tone less-controlled, and it worked great for them, should work for you! |
I've asked Niko about this issue. The issue topic is wide, and all three PRs (yours included) address different companies and what not. I'll get back to you. |
fixes #7
/claim #7
This article has the following advantages:
therefore I request to be assigned, I'm open to making any changes suggested
Writer's Checklist
Writing Structure
code elements
andMarkdown format
where appropriate.Fact-Checking
Asset Management
/assets
folder.YYYYMMDD_title_of_the_article_IMG_NAME_NO.png
.Interlinking
CTRL+F
to search for relevant keywords in:Glossary/Definitions
/defitnitions
folder.Review and Edit