Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOC data missing #17

Open
dbcook opened this issue Sep 20, 2022 · 7 comments
Open

LOC data missing #17

dbcook opened this issue Sep 20, 2022 · 7 comments

Comments

@dbcook
Copy link
Owner

dbcook commented Sep 20, 2022

This issue lists the bits of LOC Precision parts data that are missing from the LOC website

  • ID/OD of BT-1.90 Data now published, fixed
  • ID/OD of all cardboard tube couplers (note some data available on the Apogee website)
  • ID/OD of all cardboard tube coupler stiffeners
  • Masses of all centering rings but especially for the cluster rings where OR cannot compute it volumetrically

more coming...

@dbcook
Copy link
Owner Author

dbcook commented Oct 20, 2022

We owe LOC a spreadsheet like the one we sent to Bill listing the missing info for them to fill in.

@dbcook
Copy link
Owner Author

dbcook commented Nov 15, 2022

I've shared the spreadsheet with Dave Barber of LOC as of Nov 12, awaiting response.

@ahmedcharles
Copy link

Is there a reason that the nose cones don't have <ShoulderThickness> and <EndCapped> set correctly?

@dbcook
Copy link
Owner Author

dbcook commented Nov 30, 2022

Hi Ahmed, This is because OpenRocket 15.03 does not allow you to specify those parameters in a .orc file, although they exist in the UI. Some special effort was made to allow construction of a reasonably accurate mass/CG for LOC nose cones in the face of this limitation. There is a special note about how to handle this in the README, look for the section "Hollow One-Piece Plastic and Fiberglass Nose Cones".

@ahmedcharles
Copy link

ahmedcharles commented Nov 30, 2022

I read that before I asked the question. Is there a plan for dropping support for 15.03 so that these can be used? And note, users can't actually read the xml comments, right?

To clarify: If the comment wasn't in the file about the workaround, I would've simply submitted a PR with updated values. The comment is confusing enough that I decided to ask here first.

@dbcook
Copy link
Owner Author

dbcook commented Apr 10, 2023

Sorry for not answering this earlier, was dealing with major damage to my house at the time and I lost track of it. I was planning on retaining compatibility with 15.03 on at least a GA-2 basis, I.e. until there have been at least two major releases of OR. So far we’ve had one, and I imagine it will a year+ for there to be another.

I understand there have been some changes in the .orc syntax in the 22.x release, but the devs didn’t coordinate with me and I don’t know what they all are beyond the obvious ones like rail button support.

On the topic of LOC parts data, I haven’t heard back from LOC after sending them the spreadsheet.

@dbcook
Copy link
Owner Author

dbcook commented Mar 18, 2024

As of now the ID/OD of the 1.90 tube have been provided on the locprecision.com website; however that's the only missing item that has been filled in. Accordingly the 1.90 tube and ring sizes have been fixed in 1.0.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants