Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why is emitting headers the default? That's a security hole #32

Open
pszabop opened this issue Nov 9, 2017 · 0 comments
Open

why is emitting headers the default? That's a security hole #32

pszabop opened this issue Nov 9, 2017 · 0 comments

Comments

@pszabop
Copy link

pszabop commented Nov 9, 2017

skipHeaders defaults to false.

This means the entire world is getting these headers, which exposes internal implementation details and is thus a security flaw:

X-RateLimit-Limit: 20
X-RateLimit-Remaining: 19
X-RateLimit-Reset: 1510250052
X-Request-Id: da62f2a0-c576-11e7-b7fc-89bce46f8f85

Please consider changing the default in the next major release.

See this article about unnecessary exposure of implementation details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pszabop