Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inject ARG on newer Docker versions. #123

Open
miracle2k opened this issue May 9, 2017 · 3 comments
Open

Do not inject ARG on newer Docker versions. #123

miracle2k opened this issue May 9, 2017 · 3 comments

Comments

@miracle2k
Copy link

https://github.com/deis/dockerbuilder/pull/118/files/13b2463d5311da00ac5125534ee7add19a89fa3a#r108909997

I think it might be a good idea to not inject the ARGs in newer Docker versions. For me, each ARG statement takes about 2 seconds to run (Running on Azure). With a bunch of config vars defined, this extends the build time by minutes for me.

As an aside I do wonder why the ARG takes so long when running on my Deis install. Building the Dockerfile directly is super fast. Is this a disk-bound operation?

@bacongobbler
Copy link
Member

In the next release we made it an opt-in approach so you shouldn't be seeing it used by default on v2.14.0.

@miracle2k
Copy link
Author

I opted in, but I only need maybe two of the 15+ config args in the Docker Build 😢 .

@Cryptophobia
Copy link

This issue was moved to teamhephy/dockerbuilder#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants