Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outstanding Questions for Zaps Contracts #1632

Open
jackburrus opened this issue Nov 6, 2024 · 0 comments
Open

Outstanding Questions for Zaps Contracts #1632

jackburrus opened this issue Nov 6, 2024 · 0 comments

Comments

@jackburrus
Copy link
Contributor

jackburrus commented Nov 6, 2024

  1. When a user opens a position via a zap, will the user receive the position as if they were opening it with the main contract? (ie. will it have an impact on portfolio positions)
  2. Can we simply have a conditional where if the user selects a non-base/shares token then the zaps contract is used, otherwise use the core contract?
  3. Are we going to have to build a more robust pricing mechanism or will our defilama API be sufficient for the Uniswap supported tokens?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant