Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquotes in markdown preview aren't rendering correctly. #3964

Open
1 of 7 tasks
BradleyFrueh opened this issue Nov 20, 2023 · 0 comments
Open
1 of 7 tasks

Blockquotes in markdown preview aren't rendering correctly. #3964

BradleyFrueh opened this issue Nov 20, 2023 · 0 comments
Labels
scope.views Related to Preview, TreeView, UI Panels, and other webviews status.triage-needed type.bug Something isn't working

Comments

@BradleyFrueh
Copy link

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • Lookup. Dendron's Lookup Command
  • Views. Dendron Preview, Tree View, Side Panels in the UI
  • Schema. Dendron Schemas
  • Pod. Data import from / export to Dendron
  • Publish. External Site Publish
  • Markdown. Markdown features, such as syntax support and features

Describe the bug

When rendering the markdown preview in dark editor themes, markdown block quotes don't render properly. Blockquotes as denoted by "> some text" represent a block of text. This feature works as intended in light editor themes, but when using dark themes like "Monokai", the block is rendered as a black rectangle. The text inside is still readable if you highlight and you can stilll click the hyperlinks. It just looks ugly in my opinion.

To Reproduce

Steps to reproduce the behavior:

  1. Open VS Code and select a dark theme
  2. Navigate to your dendron vault and open a note that utilizes block quotes.
  3. Use ctrl+k, v (or whatever keyboard shortcut you have) to open markdown file in dendron's markdown preview.
  4. Scroll to the section with the blockquotes and observe the bug. (black rectangle)

Expected behavior

The expected behavior is to render a rectangle to display the text. The background of the block should be white even when using dark themes. I should be able to read what's inside the blockquotes, instead of an opaque rectangle.

Screenshots

image

Desktop (please complete the following information)

  • OS: Windows 10
  • Browser (if with published websites; include version): n/a
  • Versions (all that apply to bug):
    • Dendron Extension: v0.124.0
    • VS Code version: 1.84
    • Dendron CLI: n/a

Additional context

n/a

Dendron Log file

{"level":30,"time":1700509023273,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"Logger:configure","msg":"exit","logLevel":"info"}
{"level":30,"time":1700509023467,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"_activate","stage":"prod","isDebug":false,"logLevel":"info","logPath":"c:\Users\G056220\AppData\Roaming\Code\logs\20231120T101741\window3\exthost\dendron.dendron","extensionPath":"c:\Users\G056220\.vscode\extensions\dendron.dendron-0.124.0","extensionUri":"c:\Users\G056220\.vscode\extensions\dendron.dendron-0.124.0","workspaceFolders":["o:\rsch\RAU\projects\Brad\Projects\git\GITLAB\Dendron-Vault"]}
{"level":30,"time":1700509023611,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"No cache path for Segment specified. Failed event uploads will not be retried."}
{"level":30,"time":1700509023614,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"user telemetry setting: enabled by config"}
{"level":30,"time":1700509023614,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"telemetry initializing"}
{"level":30,"time":1700509023614,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"using existing id"}
{"level":30,"time":1700509023615,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"anonymous id","anonymousId":"9m7z29wceoqbm0lv35u665r"}
{"level":30,"time":1700509023635,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"DendronExtension","msg":"initialized"}
{"level":30,"time":1700509032034,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"_activate","msg":"initializeWorkspace","wsType":"NATIVE","currentVersion":"0.124.0","previousGlobalVersion":"0.124.0","extensionInstallStatus":"NO_CHANGE"}
{"level":30,"time":1700509032196,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"WorkspaceActivator.init:postSetupTraits","wsRoot":"o:\rsch\RAU\projects\Brad\Projects\git\GITLAB\Dendron-Vault"}
{"level":30,"time":1700509032263,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"runMigrationsIfNecessary","changes":[],"workspaceInstallStatus":"NO_CHANGE"}
{"level":30,"time":1700509032263,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"WorkspaceActivator.init:postMigration","wsRoot":"o:\rsch\RAU\projects\Brad\Projects\git\GITLAB\Dendron-Vault"}
{"level":30,"time":1700509032325,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"WorkspaceActivator.init:postWsServiceInitialize","wsRoot":"o:\rsch\RAU\projects\Brad\Projects\git\GITLAB\Dendron-Vault"}
{"level":30,"time":1700509032398,"pid":17104,"hostname":"WIN10VM222","name":"execServer","state":"enter"}
{"level":30,"time":1700509032438,"pid":17104,"hostname":"WIN10VM222","name":"execServer","state":"post:exec.node"}
{"level":30,"time":1700509034718,"pid":11324,"hostname":"WIN10VM222","name":"SegmentClient","msg":"No cache path for Segment specified. Failed event uploads will not be retried."}
{"level":30,"time":1700509034718,"pid":11324,"hostname":"WIN10VM222","name":"SegmentClient","msg":"user telemetry setting: enabled by config"}
{"level":30,"time":1700509034720,"pid":11324,"hostname":"WIN10VM222","name":"SegmentClient","msg":"telemetry initializing"}
{"level":30,"time":1700509034721,"pid":11324,"hostname":"WIN10VM222","name":"SegmentClient","msg":"using existing id"}
{"level":30,"time":1700509034722,"pid":11324,"hostname":"WIN10VM222","name":"SegmentClient","msg":"anonymous id","anonymousId":"9m7z29wceoqbm0lv35u665r"}
{"level":30,"time":1700509034855,"pid":17104,"hostname":"WIN10VM222","name":"execServer","state":"message","message":"49376"}
{"level":30,"time":1700509034856,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"handleServerProcess","msg":"subprocess running","pid":11324}
{"level":30,"time":1700509034856,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"startServerProcess","msg":"post-start-server","port":49376,"durationStartServer":2481}
{"level":30,"time":1700509034951,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"WorkspaceActivator.init:verifyOrStartServerProcess","port":49376}
{"level":30,"time":1700509034973,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"WorkspaceActivator.init:exit"}
{"level":30,"time":1700509035002,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"user telemetry setting: enabled by config"}
{"level":30,"time":1700509035003,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"telemetry initializing"}
{"level":30,"time":1700509035003,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"using existing id"}
{"level":30,"time":1700509035004,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"anonymous id","anonymousId":"9m7z29wceoqbm0lv35u665r"}
{"level":30,"time":1700509035004,"pid":17104,"hostname":"WIN10VM222","name":"dendron","msg":"Telemetry is disabled? false"}
{"level":30,"time":1700509035004,"pid":17104,"hostname":"WIN10VM222","name":"dendron","msg":"Segment Residual Cache Path is at c:\Users\G056220\AppData\Roaming\Code\User\globalStorage\dendron.dendron\segmentresidualcache.log"}
{"level":30,"time":1700509035004,"pid":17104,"hostname":"WIN10VM222","name":"SegmentClient","msg":"Attempting to flush residual segment data from file."}
{"level":30,"time":1700509035082,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"_activate:postSetupWorkspace","platform":"win32","extensions":[{"id":"dendron.dendron","version":"0.124.0","active":true},{"id":"dendron.dendron-paste-image","version":"1.1.1","active":false},{"id":"dendron.dendron-markdown-shortcuts"},{"id":"redhat.vscode-yaml","version":"1.14.0","active":false}],"vaults":[{"fsPath":".","selfContained":true,"name":"Dendron-Vault"}]}
{"level":30,"time":1700509035083,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"dendron.reloadIndex:run","msg":"pre-execute"}
{"level":30,"time":1700509035084,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"ReloadIndex.execute","msg":"enter"}
{"level":30,"time":1700509035572,"pid":11324,"hostname":"WIN10VM222","name":"logger","ctx":"parsingSchemas","fname":"daily","root":{"fsPath":".","selfContained":true,"name":"Dendron-Vault"}}
{"level":30,"time":1700509035746,"pid":11324,"hostname":"WIN10VM222","name":"logger","ctx":"parsingSchemas","fname":"dendron.meet","root":{"fsPath":".","selfContained":true,"name":"Dendron-Vault"},"imports":[]}
{"level":30,"time":1700509035748,"pid":11324,"hostname":"WIN10VM222","name":"logger","ctx":"parsingSchemas","fname":"people","root":{"fsPath":".","selfContained":true,"name":"Dendron-Vault"},"imports":[]}
{"level":30,"time":1700509035759,"pid":11324,"hostname":"WIN10VM222","name":"logger","ctx":"parsingSchemas","fname":"projects","root":{"fsPath":".","selfContained":true,"name":"Dendron-Vault"}}
{"level":30,"time":1700509035761,"pid":11324,"hostname":"WIN10VM222","name":"logger","ctx":"parsingSchemas","fname":"time","root":{"fsPath":".","selfContained":true,"name":"Dendron-Vault"},"imports":[]}
{"level":30,"time":1700509035762,"pid":11324,"hostname":"WIN10VM222","name":"logger","ctx":"parsingSchemas","fname":"root","root":{"fsPath":".","selfContained":true,"name":"Dendron-Vault"},"imports":[]}
{"level":30,"time":1700509039837,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"ReloadIndex.execute","durationEngineInit":4655}
{"level":30,"time":1700509039837,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"ReloadIndex.execute","msg":"exit"}
{"level":30,"time":1700509039837,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"dendron.reloadIndex:run","msg":"post-execute"}
{"level":30,"time":1700509039843,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"reloadWorkspace","msg":"post-ws.reloadWorkspace"}
{"level":30,"time":1700509039844,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"reloadWorkspace","msg":"exit"}
{"level":30,"time":1700509039864,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"postReloadWorkspace","msg":"same wsVersion"}
{"level":30,"time":1700509039864,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"postReloadWorkspace","msg":"exit"}
{"level":30,"time":1700509039865,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"setupViews","msg":"init:treeViewV2"}
{"level":30,"time":1700509039865,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"setupBacklinkTreeView","msg":"init:backlinks"}
{"level":30,"time":1700509040203,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"WorkspaceActivator:activate","msg":"fin startClient","durationReloadWorkspace":4814}
{"level":30,"time":1700509040203,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"activateWorkspace","stage":"prod","msg":"enter"}
{"level":30,"time":1700509040232,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"togglePluginActiveContext","state":"togglePluginActiveContext: true"}
{"level":30,"time":1700509040309,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"showWelcomeOrWhatsNew","version":"0.124.0","previousExtensionVersion":"0.0.0"}
{"level":30,"time":1700509041696,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"updateDecorations","msg":"decorating...","payload":{"decorationsLength":3,"diagnosticsLength":0}}
{"level":30,"time":1700509041764,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"dendron.togglePreview:run","msg":"pre-execute"}
{"level":30,"time":1700509042064,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"dendron.togglePreview:run","msg":"post-execute"}
{"level":30,"time":1700509042115,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"updateDecorations","msg":"decorating...","payload":{"decorationsLength":3,"diagnosticsLength":0}}
{"level":30,"time":1700509047283,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"dendron.dev.openLogs:run","msg":"pre-execute"}
{"level":30,"time":1700509047284,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"execute","opts":{}}
{"level":30,"time":1700509047325,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"dendron.dev.openLogs:run","msg":"post-execute"}
{"level":30,"time":1700509047348,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"WindowWatcher:onDidChangeVisibleTextEditors","editorPaths":[]}
{"level":30,"time":1700509047350,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"refreshBacklinksChangeActiveTextEditor"}
{"level":30,"time":1700509047398,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"WindowWatcher:onDidChangeVisibleTextEditors","editorPaths":["c:\Users\G056220\AppData\Roaming\Code\logs\20231120T101741\window3\exthost\dendron.dendron\dendron.log"]}
{"level":30,"time":1700509047401,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"refreshBacklinksChangeActiveTextEditor"}
{"level":30,"time":1700509047414,"pid":17104,"hostname":"WIN10VM222","name":"dendron","ctx":"WorkspaceWatcher:onFirstOpen","msg":"enter","fname":"dendron.log"}

@github-actions github-actions bot added scope.views Related to Preview, TreeView, UI Panels, and other webviews status.triage-needed type.bug Something isn't working labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope.views Related to Preview, TreeView, UI Panels, and other webviews status.triage-needed type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant