Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color of page link is wrong when immediately following a TODO [w] #3991

Open
3 of 11 tasks
M-Fabian opened this issue Aug 16, 2024 · 0 comments
Open
3 of 11 tasks

Color of page link is wrong when immediately following a TODO [w] #3991

M-Fabian opened this issue Aug 16, 2024 · 0 comments
Labels
scope.markdown Relating to markdown features (i.e. supporting new language syntax) status.triage-needed type.bug Something isn't working

Comments

@M-Fabian
Copy link

M-Fabian commented Aug 16, 2024

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • Lookup. Dendron's Lookup Command
  • Views. Dendron Preview, Tree View, Side Panels in the UI
  • Schema. Dendron Schemas
  • Pod. Data import from / export to Dendron
  • Publish. External Site Publish
  • Markdown. Markdown features, such as syntax support and features

Describe the bug

The syntax highlighting for page links immediately following a TODO bracket [ ] fails if the bracket contains something else than a space or an x. It looks to me as if it was interpreted as a link of the form [caption](link). Despite the wrong syntax highlighting, the links work normally.

To Reproduce

Add the following text to any dendron page. The TODOs 5 and 6 are highlighted incorrectly.

  • [[notes]] Existing page, blue link.
  • [[doesnotexist]] Non-existing page, yellow link.
  • [[notes]] Existing page, blue link.
  • [[doesnotexist]] Non-existing page, yellow link.
  • [w] [[notes]] The link works but the syntax highlighting is wrong.
  • [w] [[doesnotexist]] Same here.
  • [w] Text before the link fixes syntax highlighting [[notes]] as shown here.
  • [w] Same here [[doesnotexist]].

Expected behavior

I expect the syntax highlighting to be correct. At least TODO brackets containing the characters suggested in the documentation should work, namely xw?>. Ideally it should work for any single character I put in the TODO bracket.

Screenshots

screenshot

Desktop (please complete the following information)

  • OS: Windows 10
  • Versions (all that apply to bug):
    • Dendron Extension: v0.124.0
    • VS Code version: 1.85.2
    • Dendron CLI:
@github-actions github-actions bot added scope.markdown Relating to markdown features (i.e. supporting new language syntax) status.triage-needed type.bug Something isn't working labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope.markdown Relating to markdown features (i.e. supporting new language syntax) status.triage-needed type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant