Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vite still can't resolve local module in deno workspace #26721

Closed
umajho opened this issue Nov 4, 2024 · 5 comments · Fixed by #27020
Closed

vite still can't resolve local module in deno workspace #26721

umajho opened this issue Nov 4, 2024 · 5 comments · Fixed by #27020
Assignees
@marvinhagemeister
Labels
bundler-resolution Issues caused by bundlers not supporting Deno resolution needs investigation requires further investigation before determining if it is an issue or not node resolution

Comments

@umajho
Copy link

umajho commented Nov 4, 2024 •
edited
Loading

Version: Deno 2.0.4

This is a continuation of #26138 that has been closed. It seems that the problem described in that issue still exists.

I have made two reproductions:

  • the 1st one is based on the reproduction for the issue mentioned before (using SvelteKit),
  • the 2nd one is the minimum reproduction of what I have encountered originally (using SolidJS).

Here is the repository: https://github.com/umajho/deno-vite-monorepo-reproductions

There is also an issue reported to denoland/deno-vite-plugin that seems to describe the same problem:
@umajho umajho mentioned this issue Nov 4, 2024
Closed
@bartlomieju bartlomieju added the needs investigation requires further investigation before determining if it is an issue or not label Nov 5, 2024
@bartlomieju bartlomieju added node resolution bundler-resolution Issues caused by bundlers not supporting Deno resolution labels Nov 6, 2024
@ali-issa
Copy link

Hello @bartlomieju and @marvinhagemeister,

I see that the issue has been assigned, which is great. Since our project depends on this feature, I wanted to ask if there’s an approximate timeline for when it might be addressed. If it’s likely to take some time, we’re considering alternative setups as an interim solution.

Thank you for any updates you can share!

@bartlomieju
Copy link
Member

Hey @ali-issa, sorry I missed your comment. We'll try to fix it in the next week.

@nathanwhit nathanwhit mentioned this issue Nov 23, 2024
Merged
@ali-issa
Copy link

Hey @ali-issa, sorry I missed your comment. We'll try to fix it in the next week.

No worries, @marvinhagemeister! Thanks for the update, and I appreciate the effort!

@bartlomieju
Copy link
Member

I managed to reproduce both issues. It appears to me the problem lies with @deno/vite-plugin, but I need to confirm me. Will get back to you soon.

@bartlomieju
Copy link
Member

So turns out #27020 will actually fix it. We'll try to include it in 2.1.2.

bartlomieju pushed a commit that referenced this issue Nov 28, 2024
@nathanwhit @bartlomieju
fix(info): resolve bare specifier pointing to workspace member (#27020)
27757e8 
Fixes #26721

Previously, we were applying only the import map, which would result in
`@scope/foo` expanding to (e.g.) `jsr:@scope/[email protected]`. Since that
didn't exist it would error and fail to resolve.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinhagemeister marvinhagemeister

Labels
bundler-resolution Issues caused by bundlers not supporting Deno resolution needs investigation requires further investigation before determining if it is an issue or not node resolution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(info): resolve bare specifier pointing to workspace member nathanwhit/deno
4 participants
@marvinhagemeister @bartlomieju @ali-issa @umajho