Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breadcrumb title case issue] Some breadcrumbs are displaying in Title Case instead of Sentence case as they should #19972

Open
12 tasks
FranECross opened this issue Nov 26, 2024 · 0 comments
Labels
Breadcrumbs CMS + FE component. "Owned" loosely by Public Websites. Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide

Comments

@FranECross
Copy link

FranECross commented Nov 26, 2024

Description

Randi Hecht reported in Slack some time ago an issue wherein breadcrumbs are displaying in Title Case instead of Sentence case as they should (the also reported H1 issue has been resolved as far as we know).

Amanda K looked into this:
This is more of the v3 breadcrumbs not respecting the H1 styling and incorrect capitalization and it is clearly a Drupal defect.
Which has also been identified in other places. ([Fran 2024-11-26] We believe the H1 styling has been corrected)

Events: Inconsistent breadcrumb capitalization (this one appears to be in the facility page level, not event)

[Other - Accessibility] Inconsistent breadcrumb capitalization on Lovell

Vet Center Breadcrumbs not matching H1

CMS - Breadcrumbs should use the page's H1
Which now reminds me of my comment on the Events ticket from the AP QA review.

When AP updated to V3 breadcrumbs, this issue was resolved. Since this issue involves an important sign in page and across Drupal products, not just events (current AP priority), a product question remains, should a team prioritize a fix in content build since the timing of a full AP rollout is TBD? (edited)

Additional Information

We are pursuing a fix in content build because this affects more than just Events. As part of this ticket, the engineer should determine if this would more accurately be a fix that the CMS team should make, or if the PW or Facilities team can push ahead and fix.

User story

AS A Veteran, their caregiver, family member or survivor
I WANT a consistent look and feel across all of VA.gov
SO THAT I'm not distracted by different styles, and also so that I don't lose confidence in VA.gov providing a good and accurate experience

Engineering notes / background

Analytics considerations

Testing & QA

Scope / Impact analysis

What, if anything, could break as a result of this change?
Engineer should assess this when approaching PR.

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

  • Functional testing:
  • Code review:
  • Design review: Dave Pickett
  • Accessibility review: Laura Flannery
  • Product acceptance: Michael Skinner or Fran Cross

Acceptance criteria

ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable.

  • Determine cause of the sporadic issue of Title Case breadcrumbs vs. Sentence case
  • Determine if CMS team should actually be providing the fix
    • if so, notify Jill Adams/Fran Cross/Michael Skinner so they can communicate with Grace K
  • OR, If this can be fixed by PW or Facilities team, implement the fix
  • Accessibility review
  • Design review
  • Fran/Michael/Jill to close the loop with Randi Hecht in Slack here
@FranECross FranECross added Needs refining Issue status sitewide Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew Breadcrumbs CMS + FE component. "Owned" loosely by Public Websites. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breadcrumbs CMS + FE component. "Owned" loosely by Public Websites. Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide
Projects
None yet
Development

No branches or pull requests

1 participant