Fix eslint errors

[NicolasRitouet]

When we introduced eslint to the deployd-cli codebase, a few eslint rules were throwing errors.
In order to move fast, I decided to change the rules and throw warning instead of errors for a few rules.

In order to have a clean codebase, we need to fix the code to allow eslint to throw normal errors for these rules.

ℹ️ This ticket has been labeled first-timers-only, it means that it's only available for people who never contributed to an open-source project. Feel free to ask questions and get help on gitter.

Todo

• remove one rule at a time
• fix codebase to not have error with eslint
• commit your changes
• do the same for the next rule
• when all rules have been reactivated, send a PR (look at this free course if you don't know how to do it: https://egghead.io/lessons/javascript-how-to-collaborate-on-a-pull-request-on-github)

You can also send one PR per reactivated rules if you prefer.

rules to reactivate

• prefer-const: 1, // 4 errors
• no-unused-vars: 1, // 3 errors
• no-use-before-define: 1, // 7 errors
• one-var: 1, // 8 errors
• consistent-return: 1, // 8 errors
• no-param-reassign: 1, // 2 errors
• global-require: 1, // 2 errors
• import/no-dynamic-require: 1 // 1 error

[Logan1x]

Hey @NicolasRitouet i would like to try on this.

[NicolasRitouet]

@Logan1x Great!
Feel free to go on gitter if you need help

[NicolasRitouet]

@Logan1x
I made some changes on master, don't forget to pull from master before working on this ticket.

[Logan1x]

OK @NicolasRitouet

[Kapnobatai3434]

I'm going to tackle this.

[NicolasRitouet]

Hey John, Khushal already offered to work on this, can you coordinate with him to see how you could split the work? Le sam. 29 juil. 2017 à 13:45, John Scetinin <[email protected]> a écrit :

…

I'm going to tackle this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMhTuvDtBKYotzF0RrKl5Ik0dandWRAks5sSxtUgaJpZM4OdsTI> .

[Kapnobatai3434]

@Logan1x, Hi Kushal, could you provide status on your contribution? I wonder if we could split it up and fix those issues together?

[Logan1x]

I am @NicolasRitouet i am busy these days can you pass on someone else.Thanks.

[skathuria29]

Hey @NicolasRitouet ! Is this issue still up for grabs? I would like to work on it.