Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort containers in declared order #2843

Open
ryanbrainard opened this issue Aug 22, 2024 · 4 comments
Open

Sort containers in declared order #2843

ryanbrainard opened this issue Aug 22, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ryanbrainard
Copy link




Is your feature request related to a problem? Please describe.
When viewing a pod with multiple containers, they are displayed in alphabetical order instead of the order they are declared in the pod spec. For normal containers this isn't so much of a problem since the order is irrelevant, but for initContainers, the declared order dictates the run order. It would make it much easier to view the pod stepping through the initContainers if they were in run order.

Describe the solution you'd like
Provide a sort option for containers to sort by the same order they are declared in the pod spec. Bonus if it's the default, but certainly not a requirement.

Describe alternatives you've considered
I guess one could prefix the container names with numbers to make them sort alphabetically.

@derailed
Copy link
Owner

@ryanbrainard Thank you for this great suggestion Ryan!
I like this idea especially in light of more workloads specify multiple init cos.

@derailed derailed added the enhancement New feature or request label Aug 22, 2024
@ryanbrainard
Copy link
Author

@derailed Glad you like it! I have a basic branch of this working and happy to open a PR, but before I do, a few questions:

  • What would be a good name for this column? I used "DECLARED" for now, which is ok, but I feel like it may not be intuitive to users. Other ideas: "SPEC", "NATURAL", "DEFINED", "YAML", "INDEX" etc. Any preferences?
  • Should the values be 0-indexed or 1-indexed? The way I did it is just an incrementing value with the init containers followed by the regular containers, but I guess we could get fancy and prefix them with something like "init-" and "reg-" so they are still sortable but show the index within each array.
  • Any preferences on the keyboard shortcut, visibility, and if this is the default?

@ryanbrainard
Copy link
Author

@derailed I took a stab at the implemention in #2878

@derailed
Copy link
Owner

@ryanbrainard Thank you for the details here Ryan! I'll take a peek at the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants