Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian / gcc / g++ gcc (Debian 10.2.0-15) 10.2.0 : fails to compile #36

Open
Jegeva opened this issue Nov 2, 2020 · 3 comments · May be fixed by #46
Open

Debian / gcc / g++ gcc (Debian 10.2.0-15) 10.2.0 : fails to compile #36

Jegeva opened this issue Nov 2, 2020 · 3 comments · May be fixed by #46

Comments

@Jegeva
Copy link

Jegeva commented Nov 2, 2020

On compilation, LD complains about multiple references to "verbose" at linking

Easy to solve, ensure in the patch that :

verbose is extern in sasquatch/squashfs4.3/squashfs-tools/error.h
add "int verbose;"
in unsquashfs.c
@lorenzog
Copy link

lorenzog commented Nov 2, 2020 •
edited
Loading

Another way that worked was to use -fcommon in CFLAGS since in GCC 10 the new default is -fno-common:

CFLAGS=-fcommon ./build.sh

As the man page says, this has a slight performance cost.

@BlackTrackDragon
Copy link

Same issue on Kali/Debian with gcc (Debian 10.2.1-6) 10.2.1

Both solutions did not work for me.
@Jegeva I changed in sasquatch/squashfs4.3/squashfs-tools/error.h int verbose; to extern int verbose; and added in unsquashfs.c int verbose; after int user_xattrs = FALSE;.
Are these steps right?

Afterwards I get these errors:

/usr/bin/ld: unsquash-1.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/error.h:34: multiple definition of `verbose'; unsquashfs.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/unsquashfs.c:85: first defined here
/usr/bin/ld: unsquash-2.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/error.h:34: multiple definition of `verbose'; unsquashfs.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/unsquashfs.c:85: first defined here
/usr/bin/ld: unsquash-3.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/error.h:34: multiple definition of `verbose'; unsquashfs.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/unsquashfs.c:85: first defined here
/usr/bin/ld: unsquash-4.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/error.h:34: multiple definition of `verbose'; unsquashfs.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/unsquashfs.c:85: first defined here
/usr/bin/ld: compressor.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/error.h:34: multiple definition of `verbose'; unsquashfs.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/unsquashfs.c:85: first defined here
/usr/bin/ld: unsquashfs_info.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/error.h:34: multiple definition of `verbose'; unsquashfs.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/unsquashfs.c:85: first defined here
/usr/bin/ld: unsquashfs_xattr.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/error.h:34: multiple definition of `verbose'; unsquashfs.o:/home/jk2210/sasquatch/squashfs4.3/squashfs-tools/unsquashfs.c:85: first defined here
collect2: error: ld returned 1 exit status
make: *** [Makefile:298: sasquatch] Error 1

@BlackTrackDragon
Copy link

After testing @lorenzog answer, it works.

This was referenced Apr 21, 2021
Closed
Closed
@sevrb sevrb mentioned this issue Nov 9, 2021
Open
@mzpqnxow mzpqnxow mentioned this issue Jan 13, 2022
Closed
mzpqnxow added a commit to mzpqnxow/sasquatch that referenced this issue Jan 13, 2022
@mzpqnxow
add second patch to address issue devttys0#36; should be coalesced in…
6854267 
…to one full/clean patch
@mzpqnxow mzpqnxow linked a pull request Jan 13, 2022 that will close this issue
Open
mzpqnxow added a commit to mzpqnxow/sasquatch that referenced this issue Feb 6, 2022
@mzpqnxow
Add patch for devttys0#36
b7fc759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address issue #36 mzpqnxow/sasquatch
3 participants
@lorenzog @Jegeva @BlackTrackDragon