Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take a look at Ory Fosite #2061

Open
sagikazarmark opened this issue Mar 25, 2021 · 2 comments
Open

Take a look at Ory Fosite #2061

sagikazarmark opened this issue Mar 25, 2021 · 2 comments

Comments

@sagikazarmark
Copy link
Member

Fosite is an OAuth 2.0 and OIDC framework used in Ory Hydra. Let's take a look at it to see if we can use it in Dex and collaborate on it.

It looks promising and it fixes a couple known issues in Dex, but I haven't looked deeply at it.

cc @aeneasr

@nabokihms
Copy link
Member

I briefly looked through the documentation, and I'm tempted. We can abstain from a lot of code that requires refactoring and focus on connectors / storages / middlewares.

Some concerns (but I need to deep dive into the fosite documentation to prove them for myself):

  1. Dex doesn't accept all options, e.g., max_age, login_prompt, login_hint, and it can be hard to integrate them with callback connectors. (Is it possible to customize acceptable options?)
  2. It looks like we will have to refactor the whole storage (what can be a huge breaking change).

@sagikazarmark
Copy link
Member Author

I'm trying to pick this one up (partly to do some research for #1629).

As for your concerns:

  1. I think it's okay to rewrite certain components for our use cases.
  2. Maybe we can use the existing storage layer to implement the one in fosite and implement the rest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants