Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Connector: support Application Default Credential (ADC) #2626

Closed
2 tasks done
chr-b opened this issue Aug 10, 2022 · 3 comments
Closed
2 tasks done

Google Connector: support Application Default Credential (ADC) #2626

chr-b opened this issue Aug 10, 2022 · 3 comments

Comments

@chr-b
Copy link

chr-b commented Aug 10, 2022

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

The Google provider documentation for fetching groups requires the parameter serviceAccountFilePath.

When DEX is running on GCP, there is no need to export a GCP service account credential and make it available as serviceAccountFilePath. In fact, it is bad security practice to generate long-term credentials such as GCP service account user-managed keys.

Proposed Solution

If no serviceAccountFilePath is provided, obtain the Application Default Credential (ADC) from the environment.

See https://pkg.go.dev/cloud.google.com/go#hdr-Authentication_and_Authorization

Alternatives Considered

No response

Additional Information

To my understanding, the adminEmail is also no longer needed either. You can have the GCP service account access the GSuite directory API directly, without having to impersonate another user: https://support.google.com/a/answer/162106#zippy=%2Cset-up-domain-wide-delegation-for-a-client

@nabokihms
Copy link
Member

Related #2530

@mariadb-ChristianBauer
Copy link

Yes, this can be closed as the feature was shipped with the v2.34.0 release.

@nabokihms
Copy link
Member

I am closing the issue. Feel free to reopen it or open a new one if something is left to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants