Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only initialize the admin service if necessary #2699

Closed
3 tasks done
sagikazarmark opened this issue Oct 5, 2022 · 0 comments · Fixed by #2700
Closed
3 tasks done

Only initialize the admin service if necessary #2699

sagikazarmark opened this issue Oct 5, 2022 · 0 comments · Fixed by #2700

Comments

@sagikazarmark
Copy link
Member

sagikazarmark commented Oct 5, 2022

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.

Version

2.34.0

Storage Type

In-memory

Installation Type

Official container image, Official Helm chart

Expected Behavior

Improper configuration of admin service does not lead to errors when the admin service is not used at all.

Actual Behavior

Since 2.34.0 if a service account is not configured, the admin service falls back to default credentials. This causes problems on GKE: #2676

Steps To Reproduce

No response

Additional Information

When the groups scope is present AND admin service is not configured properly, Dex <2.34 fails anyway (I believe it may even panic), so not restoring prior behavior completely should be okay.

Proposed solution: when the groups scope is present, initialize the admin service with whatever configuration is present.

Correction, Dex opts to not fetch the groups in this case.

Configuration

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant