Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Google admin service optional #2701

Open
2 tasks done
sagikazarmark opened this issue Oct 5, 2022 · 0 comments
Open
2 tasks done

Make Google admin service optional #2701

sagikazarmark opened this issue Oct 5, 2022 · 0 comments
Milestone

Comments

@sagikazarmark
Copy link
Member

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

Prior to 2.34, using the admin service for groups was optional. It was implicitly enabled by adding a service account path and an admin email address to the configuration.

2.34 added support for falling back to default credentials which (with some of the changes added in 2.35) introduced a number of issues:

Instead of implicitly enabling the admin service, it became enabled by default and that led to issues in certain environments.

Proposed Solution

Enable the admin service explicitly in configuration (with a fallback to the <2.34 behavior).

Although this would be a breaking change (well, compared to 2.34 and 2.35), it still seems to be the better option given that enabling it by default leads to various issues.

Alternatives Considered

It's worth mentioning that the admin service is currently only required if the groups scope is requested. As a temporary workaround #2700 makes the admin service optional, unless the scope is requested.

With the groups scope requested it seems to be somewhat counterintuitive not to require the admin service. Whether it's a hard or soft requirement (resulting in a warning or a failure) is up for debate.

#2122 implements an interesting alternative where using default credentials is configurable and admin impersonation seems to work better too.

Additional Information

We need a way to verify and test the behavior, preferably using automated tests.

@sagikazarmark sagikazarmark added this to the v2.36.0 milestone Oct 5, 2022
@nabokihms nabokihms modified the milestones: v2.36.0, v2.37.0 Mar 6, 2023
@sagikazarmark sagikazarmark modified the milestones: v2.37.0, v2.38.0 May 12, 2023
@sagikazarmark sagikazarmark modified the milestones: v2.38.0, v2.39.0 Jan 25, 2024
@nabokihms nabokihms modified the milestones: v2.39.0, v2.40.0 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants