Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dex to start its server if one or more connectors fails to initiialize #2787

Closed
2 tasks done
dlipovetsky opened this issue Jan 12, 2023 · 2 comments
Closed
2 tasks done

Comments

@dlipovetsky
Copy link
Contributor

dlipovetsky commented Jan 12, 2023

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

Dex initializes every connector when its server starts. If one connector fails to initialize, dex exits.

Dex exits even if other connectors are available and successfully initialized. This provides a bad user experience. For example, if a user adds a new OIDC connector but misconfigures it, existing users connecting via a correctly configured LDAP connector will be unable to authenticate.

By comparison, once the server is running, dex may need to initialize a new connector. If that connector fails to initialize, dex does not exit, but only returns an error to the client.

It therefore appears safe for dex to start its server if one or more connectors fails to initialize.

Proposed Solution

Allow dex to start its server if one or more connectors fails to initiialize.

If the current behavior (exiting) should remain the default, the new behavior can be enabled with a flag.

Alternatives Considered

No response

Additional Information

No response

@dlipovetsky dlipovetsky changed the title Do not exit if a connector fails to open on server initialization Allow dex to start its server if one (or more) connector fails to initiialize Jan 12, 2023
@dlipovetsky dlipovetsky changed the title Allow dex to start its server if one (or more) connector fails to initiialize Allow dex to start its server if one or more connectors fails to initiialize Jan 12, 2023
@nabokihms
Copy link
Member

Hello! it seems like a duplicate of #1723
The issue is valid, and we appreciate any help with resolving it.

Closing it as a duplicate.

@dlipovetsky
Copy link
Contributor Author

Hello! it seems like a duplicate of #1723 The issue is valid, and we appreciate any help with resolving it.

Closing it as a duplicate.

Thanks for triaging!

Sorry, I missed #1723. To be fair, a few connectors make network calls during initialization: OIDC, Google, and OpenShift. And all connectors could, in general, fail to initialize.

I can copy my description over to #1723.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants