Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Type Fuzzy Matching #48

Open
dills122 opened this issue Jun 16, 2019 · 0 comments
Open

Refactor Type Fuzzy Matching #48

dills122 opened this issue Jun 16, 2019 · 0 comments
Labels
enhancement New feature or request refactor Refactoring needed

Comments

@dills122
Copy link
Owner

Type fuzzy matching in its current form is to complicated and not very accurate in some cases.
It needs an overhaul to better match types and handle compound types.

Example:
Artifact Creature would return Creature, but in this case Artifact should take president over Creature` for a smaller sample size.

Also Creature is way to dominate in the decision for type fuzzy matching currently.

Refactoring into a class based structure would be idea.

Consulting Magic's type rules and statistics would be helpful for this to better improve the accuracy of the matching.

Files:
https://github.com/dills122/MTG-Card-Analyzer/blob/master/src/fuzzy-matching/match-type.js

https://github.com/dills122/MTG-Card-Analyzer/blob/master/src/fuzzy-matching/type-mapping.js

@dills122 dills122 added enhancement New feature or request refactor Refactoring needed labels Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactoring needed
Projects
None yet
Development

No branches or pull requests

1 participant