Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on as key is dumped as 'on' #86

Closed
gizmomogwai opened this issue Jan 28, 2018 · 4 comments
Closed

on as key is dumped as 'on' #86

gizmomogwai opened this issue Jan 28, 2018 · 4 comments

Comments

@gizmomogwai
Copy link

e.g. travis ghpages deploy likes:

on:
  branch: master

if i write this with dyaml i get 'on' ...
i think its not necessary to escape on, On, Off, .. on the left side of a colon.

@Herringway
Copy link
Member

It is. YAML 1.1 allows types other than strings to be used as keys. [0,1,2]: "hi" is legal, for example.
on (without quotation marks) is considered to be a boolean value - true.

However, YAML 1.2 only recognizes true and false as boolean values, so this won't be an issue once #110 is complete (and assuming Travis-CI supports YAML 1.2 as well)

@gizmomogwai
Copy link
Author

So this is more a travis issue? sorry for disturbing :)

@Herringway
Copy link
Member

possibly. does travis-ci fail to recognize configurations where the on key is quoted?

@gizmomogwai
Copy link
Author

don't know yet ... have to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants