-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker.images.push does not throw an exception on authentication failures #3277
Comments
frazar
added a commit
to frazar/docker-py
that referenced
this issue
Sep 13, 2024
Fixes: docker#3277 Signed-off-by: Francesco Zardi <[email protected]>
frazar
added a commit
to frazar/docker-py
that referenced
this issue
Sep 14, 2024
Fixes: docker#3277 Signed-off-by: Francesco Zardi <[email protected]>
frazar
added a commit
to frazar/docker-py
that referenced
this issue
Sep 14, 2024
When pushing an image, the server response might have status code 200 (OK) even though the operation has failed. To detect the occurrence of an error, inspect each JSON chunk in the server response and verify that no "error" field is present. Fixes: docker#3277 Signed-off-by: Francesco Zardi <[email protected]>
frazar
added a commit
to frazar/docker-py
that referenced
this issue
Sep 14, 2024
When pushing an image, the server response might have status code 200 (OK) even though the operation has failed. To detect the occurrence of an error, inspect each JSON chunk in the server response and verify that no "error" field is present. Fixes: docker#3277 Signed-off-by: Francesco Zardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when calling
images.push
, I would expect an exception if the push fails for any reason. Instead a list of strings containing json(!) is returned.In my case this was caused by using a credentials that were able to read the repository, but not to write on it.
I am using docker-py 7.1.0.
The text was updated successfully, but these errors were encountered: