Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for custom PhantomJS path #103

Open
cyberwombat opened this issue Oct 21, 2017 · 0 comments
Open

Request for custom PhantomJS path #103

cyberwombat opened this issue Oct 21, 2017 · 0 comments

Comments

@cyberwombat
Copy link

cyberwombat commented Oct 21, 2017

I use svg2png in AWS Lambdas (which do not execute npm install so the entire node_modules tree must be uploaded. This causes issues because of phantomjs-prebuild. In previous versions of svg2png I was able to overwrite the binary since it just had it downloaded but with this it becomes a bit messy.

I have forked the repo and added/modified two lines to allow for setting a path to the desired PJ binary:

https://github.com/cyberwombat/svg2png/blob/master/lib/svg2png.js#L6-L7

I can then easily add this env path to the Lambda settings.

I suppose this can be improved and not have phantomjs-prebuild used in some cases but at least this addresses the Lambda issue. Would you consider adding this (or a PR) or is this too case specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant