Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headless chrome #93

Open
pkra opened this issue Jul 5, 2017 · 4 comments
Open

headless chrome #93

pkra opened this issue Jul 5, 2017 · 4 comments

Comments

@pkra
Copy link

pkra commented Jul 5, 2017

Is there interest in switching from phantomjs to headless Chrome?

@domenic
Copy link
Owner

domenic commented Jul 5, 2017

I'm a bit torn about this. It'd almost certainly give better results. But, it requires Chrome being installed on your system, whereas the PhantomJS version is nice and self-contained.

Probably the way to go is to add an option to switch between them. I'd love to see a PR that does that.

@jthegedus
Copy link

Just linking this as a suggestion

https://github.com/graphcool/chromeless

@neocotic
Copy link

Please see PR #96. I've implemented a solution using puppeteer. I still have a something to fix with it and there are some caveats (i.e. no sync, only async), but I'd like early feedback while I work on the last fix.

@seangenabe
Copy link

I agree; puppeteer would certainly be a great replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants