Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add option to close Layout Editor without visible indicator #199

Open
Sinneida opened this issue Nov 20, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Sinneida
Copy link

Hi!
First of all, huge thanks for creating this extension, I always admire people who swiftly navigate through Gnome API in JS and create magic with it, despite working with JS/TS in my job for a few years, it still feels complicated. :)

Describe the feature you'd like
Currently when triggering Layout Editor the only option to close it by saving or discarding changes within it is to click on the indicator icon and pick proper option. I'd like to have an option to close it by clicking some keyboard button (Esc keys seems like a natural choice) to discard the changes and some other key to save my layout within editor, i.e. Enter key.

Additional context
None

@domferr
Copy link
Owner

domferr commented Nov 22, 2024

Hey thank you for sharing this! I've already implemented such feature of pressing Esc key to cancel the layout editing, HOWEVER it turned out...it doesn't work! 😢 😆

The good news is that I've already implemented a bugfix which will be released soon 🔜. Meanwhile, may I ask you which GNOME version you are using? Because I noticed such feature not working on GNOME <= 44 only. Can you confirm you are on GNOME <= 44 as well?

I always admire people who swiftly navigate through Gnome API in JS and create magic with it, despite working with JS/TS in my job for a few years, it still feels complicated. :)

Thank you so much! Any help, especially from people working daily with JS/TS, would be much appreciated. Feel free to contribute whenever you want, I'd provide any help you may need 😎

@domferr domferr added bug Something isn't working enhancement New feature or request labels Nov 22, 2024
@dzanotelli
Copy link

Same thoughts as Sinneida above, esc and enter support would be great.
I confirm esc is not working for me on Gnome 64 over Wayland, v15.0 of tiling shell.

@domferr
Copy link
Owner

domferr commented Nov 22, 2024

Thank you @dzanotelli for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants