Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing VB samples should fall back to C#, not C++ #9757

Closed
ocdtrekkie opened this issue Dec 27, 2018 · 2 comments
Closed

Missing VB samples should fall back to C#, not C++ #9757

ocdtrekkie opened this issue Dec 27, 2018 · 2 comments
Labels
docs-experience Indicates issues that are about the learn.microsoft.com experience or design [org][type][category] duplicate Indicates issues or PRs that are duplicate of existing ones [org][type][category] external Not related to content

Comments

@ocdtrekkie
Copy link

Issue description

So I was looking at a sample of the System.Net.Mail.Attachment class (I previously discovered this hole in the VB samples here: #6129 (comment)), and with my docs view set to VB, I found it extremely odd I was looking at C++ code, rather than at the very least, C# code, which I am more likely to expect. From issues like #8555, you can also see, in the lack of a VB sample, the docs site shows C++.

When failing to find a VB sample for a given snippet, Docs should really show C# because it's more similar syntax.

@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Dec 27, 2018
@ocdtrekkie
Copy link
Author

As an aside, I've converted NCLMailSync snippet 6 here: ocdtrekkie/samples@ba1ae42 which is the specific sample I was finding frustrating on https://docs.microsoft.com/en-us/dotnet/api/system.net.mail.attachment?view=netframework-4.7.2

But I am guessing I should port the rest of NCLMailSync.cs over to vb and PR the whole thing at once.

@mairaw
Copy link
Contributor

mairaw commented Feb 5, 2019

Thanks for your feedback @ocdtrekkie. Yes, I agree with you that if VB is missing, the default language should be C#. This feedback is already captured on the following issue:
MicrosoftDocs/feedback#927

As far as helping us port the samples to VB, your contribution would be super valuable and we'd welcome your PR. Probably best to do the whole file at once since we usually try to keep the languages with parity. So it would be strange to have a VB version that doesn't match the C# version of the file.

@mairaw mairaw added external Not related to content duplicate Indicates issues or PRs that are duplicate of existing ones [org][type][category] docs-experience Indicates issues that are about the learn.microsoft.com experience or design [org][type][category] and removed ⌚ Not Triaged Not triaged labels Feb 5, 2019
@mairaw mairaw closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-experience Indicates issues that are about the learn.microsoft.com experience or design [org][type][category] duplicate Indicates issues or PRs that are duplicate of existing ones [org][type][category] external Not related to content
Projects
None yet
Development

No branches or pull requests

3 participants