From 59a887634b7dd75ca4bf007f3bd6efc3515d6559 Mon Sep 17 00:00:00 2001 From: David Britch Date: Wed, 27 Nov 2024 09:59:43 +0000 Subject: [PATCH] Replace Frame with Border (#542) * Replace Frame with Border. * Replace Frame with Border. * Remove stray file. * Replace Frame with Border * Replace Frame with Border * Fix height. * Bump xcode. * Fix build and some minor improvements * Xcode --------- Co-authored-by: Gerald Versluis --- .github/workflows/build-all.yml | 10 +- .github/workflows/build-pr.yml | 10 +- .../Animations/Resources/Styles/Styles.xaml | 11 +- .../src/PointOfSale/Pages/SettingsPage.xaml | 235 ++++++---- .../WeatherTwentyOne/Pages/FavoritesPage.xaml | 269 ++++++------ .../Pages/FavoritesPage.xaml.cs | 6 +- .../WeatherTwentyOne/Pages/SettingsPage.xaml | 401 +++++++++--------- .../Platforms/Android/AndroidManifest.xml | 2 +- .../Resources/Styles/DefaultTheme.xaml | 7 +- .../BeginnersTask/MainPage.xaml | 8 +- .../Controls/CardViewUI.xaml | 34 +- .../Views/BindToViewModelPage.xaml | 20 +- .../Views/ControlTemplateStylePage.xaml | 32 +- .../RelativeSourceBindingCardViewPage.xaml | 30 +- .../Views/TemplateBindingCardViewPage.xaml | 33 +- .../Views/RelativeSourceMultiBindingPage.xaml | 17 +- .../LocalizationDemo/SettingsPage.xaml | 12 +- .../Views/CompareStateTriggerDemoPage.xaml | 13 +- .../Views/StateTriggerDemoPage.xaml | 13 +- .../Controls/GradientColorPicker.xaml | 5 +- .../Views/LinearGradientBrushDemoPage.xaml | 57 ++- .../Views/RadialGradientBrushDemoPage.xaml | 55 ++- .../Views/SolidColorBrushDemoPage.xaml | 54 ++- .../Views/UpdateBrushDemoPage.xaml | 43 +- .../Views/UpdateBrushDemoPage.xaml.cs | 6 +- .../ControlGallery/ControlGallery.csproj | 13 +- .../Views/XAML/CarouselViewDemoPage.xaml | 16 +- .../Views/XAML/FlexLayoutDemoPage.xaml | 25 +- .../Views/XAML/FrameDemoPage.xaml | 19 - .../Views/XAML/FrameDemoPage.xaml.cs | 13 - .../Views/XAML/IndicatorViewDemoPage.xaml | 20 +- .../ControlGallery/Views/XAML/MainPage.xaml | 4 - .../Views/CatalogItemsPage.xaml | 25 +- .../Views/Code/CombinedStackLayoutPage.cs | 85 ++-- .../Views/XAML/CombinedStackLayoutPage.xaml | 36 +- .../Views/UserSummaryPage.xaml | 15 +- .../ThemingDemo/Views/UserSummaryPage.xaml | 15 +- .../EmptyViewDataTemplateSelectorPage.xaml | 16 +- .../EmptyView/EmptyViewFilteredPage.xaml | 16 +- .../EmptyViewLoadSimulationPage.xaml | 16 +- .../Views/EmptyView/EmptyViewSwapPage.xaml | 16 +- .../EmptyView/EmptyViewTemplatePage.xaml | 16 +- .../EmptyViewWithViewsFilteredPage.xaml | 16 +- .../HorizontalLayoutWithIndicatorsPage.xaml | 16 +- .../CurrentItemAndPositionBindingsPage.xaml | 16 +- .../CurrentItemAndPositionPage.xaml | 16 +- .../SetCurrentItemAndPositionPage.xaml | 16 +- .../Views/Interaction/VisualStatesPage.xaml | 17 +- ...izontalLayoutDataTemplateSelectorPage.xaml | 36 +- .../Layout/HorizontalLayoutPeekAreaPage.xaml | 17 +- .../Layout/HorizontalTemplateLayoutPage.xaml | 16 +- .../HorizontalTemplateLayoutRTLPage.xaml | 16 +- .../Layout/VerticalTemplateLayoutPage.xaml | 20 +- .../HorizontalPullToRefreshPage.xaml | 16 +- .../VerticalPullToRefreshPage.xaml | 16 +- .../Scrolling/IncrementalLoadingPage.xaml | 16 +- .../ItemsUpdatingScrollModePage.xaml | 16 +- .../Views/Scrolling/ScrollToByIndexPage.xaml | 16 +- .../Views/Scrolling/ScrollToByObjectPage.xaml | 16 +- .../Views/Scrolling/SnapPointsPage.xaml | 15 +- .../Views/Sizing/DynamicSizeItemsPage.xaml | 19 +- .../Views/Sizing/DynamicSizeItemsPage.xaml.cs | 4 +- .../Views/Spacing/HorizontalSpacingPage.xaml | 16 +- .../Views/Spacing/VerticalSpacingPage.xaml | 16 +- .../Views/Swipe/HorizontalSwipeItemsPage.xaml | 18 +- .../Views/BasicIndicatorViewPage.xaml | 20 +- .../Views/ConfigurableIndicatorViewPage.xaml | 18 +- .../Views/TemplatedIndicatorViewPage.xaml | 16 +- .../Views/SwipeViewCustomItemPage.xaml | 12 +- .../Views/TwoPaneView/MainPage.xaml | 4 +- 70 files changed, 1106 insertions(+), 1099 deletions(-) delete mode 100644 9.0/UserInterface/ControlGallery/ControlGallery/Views/XAML/FrameDemoPage.xaml delete mode 100644 9.0/UserInterface/ControlGallery/ControlGallery/Views/XAML/FrameDemoPage.xaml.cs diff --git a/.github/workflows/build-all.yml b/.github/workflows/build-all.yml index 65ae7932d..6b426ab7a 100644 --- a/.github/workflows/build-all.yml +++ b/.github/workflows/build-all.yml @@ -23,10 +23,9 @@ jobs: - name: Install .NET MAUI Workload run: dotnet workload install maui - # if: runner.os == 'macOS' # reenable when .NET 8 is default on hosted runners - name: Select Xcode Version - run: sudo xcode-select -s /Applications/Xcode_16.app + run: sudo xcode-select -s /Applications/Xcode_16.1.app if: runner.os == 'macOS' - name: Find and build all C# projects @@ -75,7 +74,12 @@ jobs: $proj_dir = [System.IO.Path]::GetDirectoryName($csproj) Write-Output "Cleaning up bin & obj in $proj_dir" - Get-ChildItem -Path $proj_dir -Directory -Recurse -Include bin,obj | Remove-Item -Recurse -Force + + try { + Get-ChildItem -Path $proj_dir -Directory -Recurse -Include bin,obj | Remove-Item -Recurse -Force + } catch { + Write-Output "::warning:: Failed to clean up bin & obj in $proj_dir" + } Write-Output "::endgroup::" } diff --git a/.github/workflows/build-pr.yml b/.github/workflows/build-pr.yml index 3120e8da0..25f36d19b 100644 --- a/.github/workflows/build-pr.yml +++ b/.github/workflows/build-pr.yml @@ -27,10 +27,9 @@ jobs: - name: Install .NET MAUI Workload run: dotnet workload install maui - # if: runner.os == 'macOS' # reenable when .NET 8 is default on hosted runners - name: Select Xcode Version - run: sudo xcode-select -s /Applications/Xcode_16.app + run: sudo xcode-select -s /Applications/Xcode_16.1.app if: runner.os == 'macOS' - name: Find and build changed projects @@ -112,7 +111,12 @@ jobs: $proj_dir = [System.IO.Path]::GetDirectoryName($projectToBuild) Write-Output "Cleaning up bin & obj in $proj_dir" - Get-ChildItem -Path $proj_dir -Directory -Recurse -Include bin,obj | Remove-Item -Recurse -Force + + try { + Get-ChildItem -Path $proj_dir -Directory -Recurse -Include bin,obj | Remove-Item -Recurse -Force + } catch { + Write-Output "::warning:: Failed to clean up bin & obj in $proj_dir" + } Write-Output "::endgroup::" } diff --git a/9.0/Animations/Animations/Resources/Styles/Styles.xaml b/9.0/Animations/Animations/Resources/Styles/Styles.xaml index 67fa3644e..b129f13f3 100644 --- a/9.0/Animations/Animations/Resources/Styles/Styles.xaml +++ b/9.0/Animations/Animations/Resources/Styles/Styles.xaml @@ -7,11 +7,10 @@ - + - + + + + - -