Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP] Metrics test fails on Mac locally #91721

Closed
ManickaP opened this issue Sep 7, 2023 · 3 comments
Closed

[HTTP] Metrics test fails on Mac locally #91721

ManickaP opened this issue Sep 7, 2023 · 3 comments
Assignees
Milestone

Comments

@ManickaP
Copy link
Member

ManickaP commented Sep 7, 2023

HttpMetricsTest_Http11_Async_HttpMessageInvoker.RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded

Fails for me locally on each run. MacOS Ventura Version 13.5 (22G74) x64

System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker.RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded [FAIL]
        Assert.Contains() Failure
        Not found: HttpRequestException
        In value:  String[] ["TaskCanceledException", "response_ended"]
        Stack Trace:
          /Users/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs(103,0): at System.Net.Http.Functional.Tests.HttpMetricsTestBase.VerifyRequestDuration(String instrumentName, Double measurement, KeyValuePair`2[] tags, Uri uri, Version protocolVersion, Nullable`1 statusCode, String method, String[] acceptedErrorReasons)
          /Users/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs(79,0): at System.Net.Http.Functional.Tests.HttpMetricsTestBase.VerifyRequestDuration(Measurement`1 measurement, Uri uri, Version protocolVersion, Nullable`1 statusCode, String method, String[] acceptedErrorReasons)
          /Users/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs(817,0): at System.Net.Http.Functional.Tests.HttpMetricsTest_Http11.<>c__DisplayClass4_0.<<RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded>b__0>d.MoveNext()
          --- End of stack trace from previous location ---
          /Users/manicka/Repositories/runtime/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(120,0): at System.Threading.Tasks.TaskTimeoutExtensions.GetRealException(Task task)
          --- End of stack trace from previous location ---
          /Users/manicka/Repositories/runtime/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(90,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks)
          /Users/manicka/Repositories/runtime/src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs(44,0): at System.Net.Test.Common.LoopbackServerFactory.<>c__DisplayClass6_0.<<CreateClientAndServerAsync>b__0>d.MoveNext()
          --- End of stack trace from previous location ---
          /Users/manicka/Repositories/runtime/src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs(107,0): at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options)
          /Users/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs(801,0): at System.Net.Http.Functional.Tests.HttpMetricsTest_Http11.RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded()
          --- End of stack trace from previous location ---

@antonfirsov Let me know if you need logs or anything, I can help debug this.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 7, 2023
@ManickaP ManickaP changed the title [HTTP] Matrics test fails on Mac locally [HTTP] Metrics test fails on Mac locally Sep 7, 2023
@ghost
Copy link

ghost commented Sep 7, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

HttpMetricsTest_Http11_Async_HttpMessageInvoker.RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded

Fails for me locally on each run. MacOS Ventura Version 13.5 (22G74) x64

System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker.RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded [FAIL]
        Assert.Contains() Failure
        Not found: HttpRequestException
        In value:  String[] ["TaskCanceledException", "response_ended"]
        Stack Trace:
          /Users/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs(103,0): at System.Net.Http.Functional.Tests.HttpMetricsTestBase.VerifyRequestDuration(String instrumentName, Double measurement, KeyValuePair`2[] tags, Uri uri, Version protocolVersion, Nullable`1 statusCode, String method, String[] acceptedErrorReasons)
          /Users/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs(79,0): at System.Net.Http.Functional.Tests.HttpMetricsTestBase.VerifyRequestDuration(Measurement`1 measurement, Uri uri, Version protocolVersion, Nullable`1 statusCode, String method, String[] acceptedErrorReasons)
          /Users/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs(817,0): at System.Net.Http.Functional.Tests.HttpMetricsTest_Http11.<>c__DisplayClass4_0.<<RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded>b__0>d.MoveNext()
          --- End of stack trace from previous location ---
          /Users/manicka/Repositories/runtime/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(120,0): at System.Threading.Tasks.TaskTimeoutExtensions.GetRealException(Task task)
          --- End of stack trace from previous location ---
          /Users/manicka/Repositories/runtime/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(90,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks)
          /Users/manicka/Repositories/runtime/src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs(44,0): at System.Net.Test.Common.LoopbackServerFactory.<>c__DisplayClass6_0.<<CreateClientAndServerAsync>b__0>d.MoveNext()
          --- End of stack trace from previous location ---
          /Users/manicka/Repositories/runtime/src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs(107,0): at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options)
          /Users/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs(801,0): at System.Net.Http.Functional.Tests.HttpMetricsTest_Http11.RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded()
          --- End of stack trace from previous location ---

@antonfirsov Let me know if you need logs or anything, I can help debug this.

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http, untriaged

Milestone: -

@karelz karelz added this to the 9.0.0 milestone Sep 7, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Sep 7, 2023
@wfurt
Copy link
Member

wfurt commented Sep 11, 2023

it fails for me as well. After the first request I see client kicking retry. The test works for me when executed in isolation as it would eventually get the OCE -> probably sign that it does not work as expected.

@MihaZupan
Copy link
Member

Duplicate of #93627

@MihaZupan MihaZupan marked this as a duplicate of #93627 Oct 19, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants