Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] [wasm][debugger] Set VSTEST_TESTHOST_SHUTDOWN_TIMEOUT to 2s #89862

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 2, 2023

Backport of #89703 to release/7.0-staging

/cc @thaystg @radical

Customer Impact

None. Only trying to get CI green.

Testing

Risk

None.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

The tests have been getting randomly aborted with:
`The active test run was aborted. Reason: Test host process crashed`

This might be due to the shutdown taking too long. The default timeout
is 100ms. Increasing that to 2000ms.

Issue: #89409
@github-actions github-actions bot requested a review from radical as a code owner August 2, 2023 16:10
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 2, 2023
@radical
Copy link
Member

radical commented Aug 2, 2023

This is a tests only change.

@thaystg thaystg added Servicing-approved Approved for servicing release and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 2, 2023
@thaystg thaystg merged commit 6f5b364 into release/7.0-staging Aug 4, 2023
@jkotas jkotas deleted the backport/pr-89703-to-release/7.0-staging branch August 27, 2023 16:55
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants