Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/msbuild #42258

Merged
merged 10 commits into from
Jul 24, 2024
Merged

[main] Update dependencies from dotnet/msbuild #42258

merged 10 commits into from
Jul 24, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 20, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: 51256791-e30b-4b96-f2b9-08daf1d75f3f
  • Build: 20240723.7
  • Date Produced: July 23, 2024 10:19:05 PM UTC
  • Commit: dd550ddf967167fcbbec13bc2ef8be9b5765d87b
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
8cd48c5 
…0719.3

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.0-preview-24368-09 -> To Version 17.12.0-preview-24369-03
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jul 20, 2024
This was referenced Jul 20, 2024
Open
Open
dotnet-maestro bot and others added 2 commits July 20, 2024 12:31
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
2a581a0 
…0719.3

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.0-preview-24368-09 -> To Version 17.12.0-preview-24369-03
@akoeplinger
Merge branch 'main' into darc-main-3c5d1eb2-a0eb-4ef0-ad37-8a59d3960703
55d99e5
This was referenced Jul 20, 2024
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
eae4845 
…0719.3

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.0-preview-24368-09 -> To Version 17.12.0-preview-24369-03
@build-analysis build-analysis bot mentioned this pull request Jul 21, 2024
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
3a780d9 
…0722.4

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.0-preview-24368-09 -> To Version 17.12.0-preview-24372-04
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
f7f5c79 
…0722.6

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.0-preview-24368-09 -> To Version 17.12.0-preview-24372-06
@nagilson
Copy link
Member

@mmitche @ViktorHofer @MichaelSimons May you take a look at VMR vertical build failing on android?

/vmr/repo-projects/Directory.Build.targets(428,5): error MSB3073: The command "/vmr/src/runtime/build.sh --restore --build --pack --publish --ci --configuration Release -bl /p:DotNetBuildRepo=true /p:DotNetBuildOrchestrator=true /p:RestoreConfigFile=/vmr/artifacts/obj/runtime/NuGet.config /p:SourceBuiltAssetsDir=/vmr/artifacts/assets/Release/ /p:SourceBuiltAssetManifestsDir=/vmr/artifacts/obj/AssetManifests/runtime/ --arch arm64 --os android /p:TargetRid=android-arm64 /p:SourceBuiltShippingPackagesDir=/vmr/artifacts/packages/Release/Shipping/runtime/ /p:SourceBuiltNonShippingPackagesDir=/vmr/artifacts/packages/Release/NonShipping/runtime/ > /vmr/artifacts/log/Release/runtime.log 2>&1" exited with code 1.

@nagilson nagilson mentioned this pull request Jul 22, 2024
Merged
@build-analysis build-analysis bot mentioned this pull request Jul 22, 2024
Open
3 tasks
@nagilson nagilson mentioned this pull request Jul 22, 2024
Merged
@nagilson
Copy link
Member

@marcpopMSFT It would be ideal to have an alias for unified build and vmr contributors. @mmitche do you have a list of people who could be added to both of these groups?

@marcpopMSFT
Copy link
Member

@dotnet/product-construction is the list you're looking for for VMR and unified build I believe.

@nagilson
Copy link
Member

Thank you.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jul 23, 2024 •
edited
Loading

The VMR failure is dotnet/msbuild#10342 which already got fixed but requires updating to a newer P7 SDK. I just reran the failing leg.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
b7b8bd7 
…0722.6

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.0-preview-24368-09 -> To Version 17.12.0-preview-24372-06
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
805709e 
…0722.6

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.0-preview-24368-09 -> To Version 17.12.0-preview-24372-06
@nagilson
Copy link
Member

nagilson commented Jul 23, 2024 •
edited
Loading

@dotnet/msbuild-admins

This change seems to have impacted some tests, they are now failing with Null character in path. It may be recognizing spaces as invalid characters, but I'm not sure. May you PTAL? Are there any reasons you could think this might happen?

@rainersigwald
Copy link
Member

rainersigwald commented Jul 23, 2024 •
edited
Loading

Nothing stands out in the commit list. Looks like all the failing tests are dotnet build on a WPF app, and the bogus string is in the wpftemp path.

@dotnet/kitten @JanKrivanek can you take a look? I'd probably aim for "can I repro locally under a debugger" next.

@rainersigwald
Copy link
Member

Actually @JanKrivanek the internal failures were ALSO wpftemp projects . . . that feels like enough smoke to look for a fire.

@rainersigwald
Copy link
Member

I repro the failure with dotnet new wpf && dotnet build -bl.

@rainersigwald rainersigwald mentioned this pull request Jul 23, 2024
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
3f94310 
…0723.7

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.12.0-preview-24368-09 -> To Version 17.12.0-preview-24373-07
@dotnet-maestro dotnet-maestro bot merged commit 0d7a9fe into main Jul 24, 2024
41 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-3c5d1eb2-a0eb-4ef0-ad37-8a59d3960703 branch July 24, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagilson nagilson nagilson approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow Area-VMR untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nagilson @marcpopMSFT @ViktorHofer @rainersigwald @akoeplinger