Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differing behaviour compared to the vscode theme #8

Open
wasi-master opened this issue Feb 2, 2022 · 1 comment
Open

Differing behaviour compared to the vscode theme #8

wasi-master opened this issue Feb 2, 2022 · 1 comment

Comments

@wasi-master
Copy link
Member

In the spec page, it says that the vscode theme is a fully spec-compliant theme 1
image

So I expected the highlightjs theme to look pretty much the same as the vscode theme. But for some reason for me, it isn't.

Highlight JS

Visual Studio Code

And yeah, I can get if fixing some of these is not possible with highlightjs. But there has to be some stuff that could be changed, right?

For example,

  • The bold+italic green text
  • The bold pink text
    I think they could be fixed pretty easily, but I am not going to open a PR just yet since I wanna know if they are intentional first
@wasi-master
Copy link
Member Author

I just saw #6 and that seems to have implemented this bold italic behavior, and @zenorocha accepted it, so I guess the behavior is accepted? I'll still keep this issue open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant