Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): Early limit cutoff #1943

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

dranikpg
Copy link
Contributor

@dranikpg dranikpg commented Sep 26, 2023

Don't return more search results than requested from core search algorithm. This is because for some queries (like the select ALL query) the result set is borrowed, which leads to a very expensive copy

Also trace the number of filtered items pre-aggregation (will only be used later)

Helper for both #1941 #1924

Signed-off-by: Vladislav Oleshko <[email protected]>
@dranikpg dranikpg marked this pull request as ready for review September 26, 2023 17:21
chakaz
chakaz previously approved these changes Sep 26, 2023
src/core/search/search.h Outdated Show resolved Hide resolved
src/core/search/search.cc Outdated Show resolved Hide resolved
src/server/search/doc_index.cc Show resolved Hide resolved
Signed-off-by: Vladislav Oleshko <[email protected]>
@dranikpg dranikpg merged commit b523f35 into dragonflydb:main Sep 27, 2023
7 checks passed
@dranikpg dranikpg deleted the search-early-limit branch November 9, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants