Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] install.sh doesn't run prereqs checks #1346

Open
4 tasks done
MrAwesome opened this issue Nov 12, 2024 · 0 comments · May be fixed by #1347
Open
4 tasks done

[Bug Report] install.sh doesn't run prereqs checks #1346

MrAwesome opened this issue Nov 12, 2024 · 0 comments · May be fixed by #1347
Labels
bug Something isn't working

Comments

@MrAwesome
Copy link

Prerequisite Steps

  • I have searched existing issues
  • This issue is not a duplicate of an existing one
  • I have checked the EmuDeck Wiki
  • I have read the Troubleshooting Page on the EmuDeck Wiki

What distro are you running?

Arch

Which SteamOS Branch are you using?

Not Using a Steam Deck

What happened?

The boolean logic at the top of install.sh means that the prereq installation code never actually runs, as far as I can tell:

-if [ $linuxID != "ChimeraOS" ]; then
...
-elif [ $linuxID != "SteamOS" ]; then

This translates to "only run prerequisite checks for ChimeraOS", which doesn't seem like the desired behavior given the code there. It's a little unclear what the logic should be, but I'm guessing it's "run prerequisite checks for everything except SteamOS". Putting up a PR with that logic in a bit.

Relevant log output

No response

@MrAwesome MrAwesome added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant