Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] How to remove the large watermarks introduced in v0.4 #4143

Closed
2 tasks done
lovasoa opened this issue Nov 23, 2024 · 4 comments
Closed
2 tasks done

[Bug] How to remove the large watermarks introduced in v0.4 #4143

lovasoa opened this issue Nov 23, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@lovasoa
Copy link

lovasoa commented Nov 23, 2024

Before you submit this issue, have you checked the following

  • Is this really a problem?
  • I have searched the Github Issues for similar issues, but did not find anything.

Affected packages and versions

v0.5.0

Reproduction link

image

Expected behavior

Same as v0.4, no watermark

Actual behavior

v0.5 introduced large watermarks on the spreadsheets. The documentation does not seem to mention how to remove them.

System information

System:
OS: Linux 6.11 Fedora Linux 41 (Workstation Edition)
CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
Memory: 6.73 GB / 15.34 GB
Container: Yes
Shell: 5.2.32 - /bin/bash
Binaries:
Node: 22.11.0 - /usr/bin/node
npm: 10.9.0 - /usr/bin/npm

@lovasoa lovasoa added the bug Something isn't working label Nov 23, 2024
@jikkai
Copy link
Member

jikkai commented Nov 25, 2024

The @univerjs-pro packages now require a valid license. Unlicensed usage will produce a watermark.

@jikkai jikkai closed this as completed Nov 25, 2024
@lovasoa
Copy link
Author

lovasoa commented Nov 25, 2024

Hello and thank you for the clarification !

I was under the impression that the entire project was under Apache-2.0, and https://univerjs/preset-sheets-advanced still indicates an apache license.

Is there somewhere users can see which project is distributed under which license ?

@jikkai
Copy link
Member

jikkai commented Nov 25, 2024

You're right about @univerjs/preset-sheets-advanced being based on Apache-2.0 and we'll open-source it soon. However, it depends on @univerjs-pro packages which are not currently open-sourced. We appreciate your understanding. 🫶

@lovasoa
Copy link
Author

lovasoa commented Nov 25, 2024

I understand what you want to do, and I am no legal expert, but I don't think you have the right to do that. You cannot list Apache-2.0 as the license in your package.json if your package has dependencies that are not open-sourced. Doing so violates the terms of the Apache-2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants