Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test for multi-part form request #10

Open
ghost opened this issue May 16, 2020 · 0 comments
Open

Remove test for multi-part form request #10

ghost opened this issue May 16, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented May 16, 2020

Hello!

In the line of code referenced you ask if that section of code is needed. I would say no.

xss-mw/xss.go

Line 376 in 7a0dab8

// XXX needed?

I am supporting a legacy application which sends data using a multi-part form. When it finishes sending, it sends a final request without any data, just form fields. I don't have access to the source, but I assume it's done in some sort of loop and when it runs out of data to send, it sends a field to indicate that no more data is coming but doesn't change the way it formats the request. This causes the application to fail as it doesn't get the response it expects.

So, I would say that it should be removed, or at least a flag to enable ignoring empty multi-part data.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants