Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it so client reconnects don't trigger a join message #1546

Open
dyc3 opened this issue Mar 21, 2024 · 0 comments
Open

make it so client reconnects don't trigger a join message #1546

dyc3 opened this issue Mar 21, 2024 · 0 comments
Labels
enhancement New feature or request server Improvements or additions to the server ui-ux/user Problem with the UI/UX from an end user perspective

Comments

@dyc3
Copy link
Owner

dyc3 commented Mar 21, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Sometimes network interruptions cause websockets to disconnect. When clients reconnect, they show a new join toast

Describe the solution you'd like

Have join room events not be sent if the client connects with reconnect=true, and also have the leave events not be triggered.

Additional context

  • Special care must be taken to not allow clients to stealthily join a room. Eg. Join for the first time without triggering a join event

related to #1527
@dyc3 dyc3 added enhancement New feature or request server Improvements or additions to the server labels Mar 21, 2024
@dyc3 dyc3 added the ui-ux/user Problem with the UI/UX from an end user perspective label Mar 21, 2024
@cjrkoa cjrkoa moved this from Todo to In Progress in OTT Horizontal Scaling Mar 31, 2024
@dyc3 dyc3 unassigned cjrkoa Apr 4, 2024
@dyc3 dyc3 moved this from In Progress to Todo in OTT Horizontal Scaling Apr 4, 2024
Repository owner deleted a comment from cjrkoa Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request server Improvements or additions to the server ui-ux/user Problem with the UI/UX from an end user perspective
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyc3 @cjrkoa