Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide standalone JavaFX implementations for toolbar actions provided by o.e.g.mvc.fx.ui #22

Open
initialflame opened this issue Aug 16, 2018 · 1 comment

Comments

@initialflame
Copy link

If you want to reuse Actions like ZoomInAction, DeleteAction, SelectAllAction from gef.mvc.fx.ui you need to have dependencies to JFace and SWT.

This is very ugly in case of a want to have a clean JavaFX-Application.

@mwienand
Copy link
Contributor

Good catch! The toolbar actions are certainly nice to have in a standalone JavaFX application, too.

The .ui modules may introduce dependencies on Eclipse UI, SWT, and JFace. However, they should only contain integration aspects, such as integration into the Eclipse Undo/Redo History, providing ViewPart and EditorPart implementations that show a GEF Viewer, providing the option to use SWT Controls inside a JavaFX Scene, etc. The main part of the framework does not introduce such dependencies, e.g. o.e.g.mvc.fx, o.e.g.zest.fx, o.e.g.fx, etc.

Rather than remove the integration aspects, we should provide implementations for such toolbar actions for standalone JavaFX applications, too. However, they probably do not belong to o.e.g.mvc.fx. Maybe we need another module. I will rename this issue accordingly.

@mwienand mwienand changed the title gef.mvc.fx.ui should not have dependencies on JFace and SWT Provide standalone JavaFX implementations for toolbar actions provided by o.e.g.mvc.fx.ui Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants