Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - Blank node IDs should be preserved for remote validation reports #4622

Closed
hmottestad opened this issue Jun 8, 2023 · 2 comments · Fixed by #4794 · May be fixed by #4624
Closed

SHACL - Blank node IDs should be preserved for remote validation reports #4622

hmottestad opened this issue Jun 8, 2023 · 2 comments · Fixed by #4794 · May be fixed by #4624
Assignees
@hmottestad
Labels
🐞 bug issue is a bug 📦 SHACL affects the SHACL validator
Milestone
4.3.7

Comments

@hmottestad
Copy link
Contributor

hmottestad commented Jun 8, 2023 •
edited
Loading

Blank node IDs should be preserved for remote validation reports because users need to be able to look up data in the repository based on the validation report model.

One typical use case is for retrieving the full SHACL Shape from the repository. PropertyShape(s) are usually blank nodes, and when the report refers to a PropertyShape it uses the blank nodes.

Another use case is where the validation report refers to a blank node from the users data that is causing the validation violation.
@hmottestad hmottestad added 🐞 bug issue is a bug 📦 SHACL affects the SHACL validator labels Jun 8, 2023
@hmottestad hmottestad added this to the 4.3.3 milestone Jun 8, 2023
@hmottestad hmottestad self-assigned this Jun 8, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Triage in RDF4J Planning Jun 8, 2023
hmottestad added a commit that referenced this issue Jun 8, 2023
@hmottestad
GH-4622 add test
1971ffa
hmottestad added a commit that referenced this issue Jun 8, 2023
@hmottestad
GH-4622 preserve blank node IDs with shacl validation reports from re…
4dc6141 
…mote repository
@hmottestad hmottestad mentioned this issue Jun 8, 2023
Open
5 tasks
@abrokenjester
Copy link
Contributor

Can you elaborate on why this is necessary?

@abrokenjester abrokenjester moved this from 🆕 Triage to 🏗 In progress in RDF4J Planning Jun 10, 2023
@hmottestad
Copy link
Contributor Author

Can you elaborate on why this is necessary?

I updated the issue.

hmottestad added a commit that referenced this issue Jun 14, 2023
@hmottestad
GH-4622 change approach to writing the validation exception to more a…
938a327 
…lign with how RDF data is typically transmitted over HTTP
hmottestad added a commit that referenced this issue Jun 17, 2023
@hmottestad
GH-4622 change approach to writing the validation exception to more a…
8865893 
…lign with how RDF data is typically transmitted over HTTP
@hmottestad hmottestad modified the milestones: 4.3.3, 4.3.4 Jul 5, 2023
@hmottestad hmottestad modified the milestones: 4.3.4, 4.3.5 Jul 22, 2023
@hmottestad hmottestad modified the milestones: 4.3.5, 4.3.6 Aug 6, 2023
@hmottestad hmottestad modified the milestones: 4.3.6, 4.3.7 Aug 27, 2023
hmottestad added a commit that referenced this issue Oct 3, 2023
@hmottestad
GH-4622 add test
078af89
hmottestad added a commit that referenced this issue Oct 3, 2023
@hmottestad
GH-4622 preserve blank node IDs with shacl validation reports from re…
7cfebab 
…mote repository
hmottestad added a commit that referenced this issue Oct 3, 2023
@hmottestad
GH-4622 change approach to writing the validation exception to more a…
5d652ee 
…lign with how RDF data is typically transmitted over HTTP
@hmottestad hmottestad mentioned this issue Oct 3, 2023
Merged
5 tasks
hmottestad added a commit that referenced this issue Oct 3, 2023
@hmottestad
GH-4622 use RDF JSON to preserve bnode identifiers in the remote shac…
8ff8859 
…l valdiation report
hmottestad added a commit that referenced this issue Oct 3, 2023
@hmottestad
GH-4622 use RDF JSON to preserve bnode identifiers in the remote shac…
13d9331 
…l valdiation report
hmottestad added a commit that referenced this issue Oct 3, 2023
@hmottestad
GH-4622 SHACL preserve bnode (simple solution) (#4794)
454436f
@hmottestad hmottestad modified the milestones: 4.3.7, 5.0.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
🐞 bug issue is a bug 📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
4.3.7
2 participants
@abrokenjester @hmottestad