Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notion of Request ID to Make Logging More Transparent #5208

Open
benherber opened this issue Nov 26, 2024 · 0 comments · May be fixed by #5209
Open

Add Notion of Request ID to Make Logging More Transparent #5208

benherber opened this issue Nov 26, 2024 · 0 comments · May be fixed by #5209
Labels
📶 enhancement issue is a new feature or improvement

Comments

@benherber
Copy link

Problem description

For larger deployments of RDF4J with multiple users, it has proven slightly difficult to trace request execution through logs without adding some notion of a 'request ID' (the thread name contains some information but not enough to fully differentiate requests).

Having such a notion in logs make the request execution more transparent by behind able to trace through all subsystems for any particular execution. Moreover, it also allows for log aggregation tools to group query execution information and glean insights that are useful in debugging and performance optimization.

Preferred solution

Add a 'request Id' to MDC such that it can be (optionally) logged if desired.

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

Tried to wrangle Tomcat and Logback for implementing a similar feature but came up short. Looks like Jakarta has tooling to aid in this when we upgrade, but that is out of reach for now it seems.

Anything else?

No response

@benherber benherber added the 📶 enhancement issue is a new feature or improvement label Nov 26, 2024
benherber pushed a commit to benherber/rdf4j that referenced this issue Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📶 enhancement issue is a new feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant