Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Flow to test PRs #12

Closed
egekorkan opened this issue Mar 17, 2024 · 4 comments
Closed

Example Flow to test PRs #12

egekorkan opened this issue Mar 17, 2024 · 4 comments

Comments

@egekorkan
Copy link
Member

In order to review the recent PRs, I was going to develop an example application that uses all the features. This will fix #7 and simplify the review process. However, given that @hidetak you are working on this, you probably already have such applications (like in your video). Can you submit this as a separate PR and we ideally update the example each time we add new features? I am open to suggestions on how to better review PRs for node-red since there is a bit more testing involved for the reviewer due to dragging buttons around

@hidetak
Copy link
Contributor

hidetak commented Mar 18, 2024

@egekorkan

Thank you for your response.
I will try to provide an example of the flow.
I am not sure if the configuration values can be reflected well in the example flow because some of the node settings are credential.
If it does not reflect well, I will try to modify it to include the node.

I will also think about how to review it.
If you review the node, would it be sufficient to check the server flow and the client flow on your PC at a minimum?

@egekorkan
Copy link
Member Author

If you review the node, would it be sufficient to check the server flow and the client flow on your PC at a minimum?

Thinking of the workflow, what I currently have is one Flow that has both but I think it would be better in the future to have two flows like you mentioned, client and server.

@hidetak
Copy link
Contributor

hidetak commented Mar 22, 2024

@egekorkan

I have added an example server and client flows.
The example flows can be loaded and run from the Import menu of the Node-RED editor.

image

This will make it easier to check how the nodes are working.

@egekorkan
Copy link
Member Author

Done via #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants