Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing writemultiple operation generation for http #1087

Open
egekorkan opened this issue Sep 15, 2023 · 2 comments
Open

Removing writemultiple operation generation for http #1087

egekorkan opened this issue Sep 15, 2023 · 2 comments
Labels
binding-http Issues related to http protocol binding

Comments

@egekorkan
Copy link
Member

However, wouldn't it be better to never generate a TD with it?

Good point, I removed it for now alongside the handleWriteMultipleProperties method in order to not confuse people. However, note that in the HTTP server, the write meta operations are actually added to the op array despite having no corresponding handler method defined:

if (anyProperties) {
const href = base + "/" + this.PROPERTY_DIR;
const form = new TD.Form(href, type);
if (allReadOnly && !allWriteOnly) {
form.op = ["readallproperties", "readmultipleproperties"];
} else if (allWriteOnly && !allReadOnly) {
form.op = ["writeallproperties", "writemultipleproperties"];
} else {
form.op = [
"readallproperties",
"readmultipleproperties",
"writeallproperties",
"writemultipleproperties",
];
}
if (!thing.forms) {
thing.forms = [];
}
thing.forms.push(form);
this.addUrlRewriteEndpoints(form, thing.forms);
}

Originally posted by @JKRhb in #1086 (comment)

@egekorkan egekorkan added the binding-http Issues related to http protocol binding label Sep 15, 2023
@danielpeintner
Copy link
Member

@relu91 what's your opinion? Should we simply remove the "multiple" op's ?

@relu91
Copy link
Member

relu91 commented Sep 20, 2023

Yes I think we should remove it as long as we don't have a clear picture on how to handle this in the TD spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding-http Issues related to http protocol binding
Projects
None yet
Development

No branches or pull requests

3 participants